You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "zhfeng (via GitHub)" <gi...@apache.org> on 2023/04/04 11:32:16 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #4739: Add back Tika component
zhfeng opened a new pull request, #4739:
URL: https://github.com/apache/camel-quarkus/pull/4739
It could close
- #4470
- #3599
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4739: Add back Tika component
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4739:
URL: https://github.com/apache/camel-quarkus/pull/4739#discussion_r1157232377
##########
poms/bom/pom.xml:
##########
@@ -6266,6 +6266,17 @@
<groupId>io.quarkiverse.tika</groupId>
<artifactId>quarkus-tika</artifactId>
<version>${quarkiverse-tika.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>commons-logging</groupId>
+ <artifactId>commons-logging</artifactId>
+ </exclusion>
+ <!-- It could be removed when https://github.com/quarkiverse/quarkus-tika/issues/109 gets resolved -->
Review Comment:
Unless we can get a quick release of `quarkus-tika` containing the fix for this, we should probably open a follow-up issue here as a reminder to remove this exclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #4739: Add back Tika component
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #4739:
URL: https://github.com/apache/camel-quarkus/pull/4739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4739: Add back Tika component
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #4739:
URL: https://github.com/apache/camel-quarkus/pull/4739#issuecomment-1495865262
> How do you think about it?
We can add it to `CQ_MAVEN_ARGS` in each of our workflow YAML files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4739: Add back Tika component
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #4739:
URL: https://github.com/apache/camel-quarkus/pull/4739#issuecomment-1495859768
@jamesnetherton It seems the maven connection timeout happens again and again. I just find
- https://github.com/actions/runner-images/issues/1499
and mentioned a work around to add
`-Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120`.
How do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4739: Add back Tika component
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4739:
URL: https://github.com/apache/camel-quarkus/pull/4739#discussion_r1157279580
##########
poms/bom/pom.xml:
##########
@@ -6266,6 +6266,17 @@
<groupId>io.quarkiverse.tika</groupId>
<artifactId>quarkus-tika</artifactId>
<version>${quarkiverse-tika.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>commons-logging</groupId>
+ <artifactId>commons-logging</artifactId>
+ </exclusion>
+ <!-- It could be removed when https://github.com/quarkiverse/quarkus-tika/issues/109 gets resolved -->
Review Comment:
I will take a new releas of `quarkus-tika` ASAP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #4739: Add back Tika component
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #4739:
URL: https://github.com/apache/camel-quarkus/pull/4739#discussion_r1157384860
##########
poms/bom/pom.xml:
##########
@@ -6266,6 +6266,17 @@
<groupId>io.quarkiverse.tika</groupId>
<artifactId>quarkus-tika</artifactId>
<version>${quarkiverse-tika.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>commons-logging</groupId>
+ <artifactId>commons-logging</artifactId>
+ </exclusion>
+ <!-- It could be removed when https://github.com/quarkiverse/quarkus-tika/issues/109 gets resolved -->
Review Comment:
It should be fine with `2.0.0.CR2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org