You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2017/07/25 16:14:54 UTC
[kudu-CR] fixed getRole() to return Role
srisaikumarr@gmail.com has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7495
Change subject: fixed getRole() to return Role
......................................................................
fixed getRole() to return Role
Change-Id: I1be0f7b1ea845e3ee7dffdab11ae63a0d91f464b
---
M java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/7495/1
--
To view, visit http://gerrit.cloudera.org:8080/7495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1be0f7b1ea845e3ee7dffdab11ae63a0d91f464b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
[kudu-CR] fixed getRole() to return Role
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
srisaikumarr@gmail.com has abandoned this change.
Change subject: fixed getRole() to return Role
......................................................................
Abandoned
will add new patch.
--
To view, visit http://gerrit.cloudera.org:8080/7495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1be0f7b1ea845e3ee7dffdab11ae63a0d91f464b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fixed getRole() to return Role
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: fixed getRole() to return Role
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7495/1//COMMIT_MSG
Commit Message:
Line 7: fixed getRole() to return Role
please follow our commit formatting guidelines (see https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines for best practices)
http://gerrit.cloudera.org:8080/#/c/7495/1/java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java
File java/kudu-client/src/main/java/org/apache/kudu/client/LocatedTablet.java:
Line 128: public Role getRole() {
this is a public API so you can't make this change without breaking users.
For the purpose of this patch you'll probably need to add a new package-protected getter for the role enum
--
To view, visit http://gerrit.cloudera.org:8080/7495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1be0f7b1ea845e3ee7dffdab11ae63a0d91f464b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] fixed getRole() to return Role
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: fixed getRole() to return Role
......................................................................
Patch Set 1:
also looks like this should be squashed into the prior commit so there is only one review rather than a series
--
To view, visit http://gerrit.cloudera.org:8080/7495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1be0f7b1ea845e3ee7dffdab11ae63a0d91f464b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: srisaikumarr@gmail.com
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No