You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Bouiaw <bo...@gmail.com> on 2009/05/04 23:25:19 UTC
Critical bugs pending on Maven clean plugin
Hi,
Sorry to write again about clean plugin, but there is currently 2 VERY big
bugs in Maven clean with no workaround.
http://jira.codehaus.org/browse/MCLEAN-32 : when you have a big project with
a lot of files (very common with war), Maven load in memory a complete
object representatof of the files that are in the target directory. With one
of our projects that have some thousand of files, Maven fails to clean
target directory with a out of memory error even if we have set XMX to 768
Mbytes !!! A rm -rf take 3 seconds and use no memory !
http://jira.codehaus.org/browse/MCLEAN-39 : if you have a symlink in your
target that for example to /home directory, run mvn clean on the project.
Result : no more files in your /home directory. mvn clean follow symlink BY
DEFAULT and there is no way to avoid that even with additional configuration
!
These are 2 oustanding issues that affect every body using Maven, I hope
Brian or anybody else will be able to fix these bugs.
Regards,
Bouiaw
Re: Critical bugs pending on Maven clean plugin
Posted by John Casey <jd...@commonjava.org>.
BTW, we're happy to accept patches! If you have code that fixes this,
please let me know. I'll review and apply where appropriate.
Bouiaw wrote:
> Hi,
>
> Sorry to write again about clean plugin, but there is currently 2 VERY big
> bugs in Maven clean with no workaround.
>
> http://jira.codehaus.org/browse/MCLEAN-32 : when you have a big project with
> a lot of files (very common with war), Maven load in memory a complete
> object representatof of the files that are in the target directory. With one
> of our projects that have some thousand of files, Maven fails to clean
> target directory with a out of memory error even if we have set XMX to 768
> Mbytes !!! A rm -rf take 3 seconds and use no memory !
>
> http://jira.codehaus.org/browse/MCLEAN-39 : if you have a symlink in your
> target that for example to /home directory, run mvn clean on the project.
> Result : no more files in your /home directory. mvn clean follow symlink BY
> DEFAULT and there is no way to avoid that even with additional configuration
> !
>
> These are 2 oustanding issues that affect every body using Maven, I hope
> Brian or anybody else will be able to fix these bugs.
>
> Regards,
> Bouiaw
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Critical bugs pending on Maven clean plugin
Posted by Brian Fox <br...@infinity.nu>.
Fair enough. I personally don't have the bandwidth to look into this
again now (i'm already looking at some release, assembly, and gpg issues
that are blockers). The last time I checked I wasn't able to reproduce
it. If someone wants to supply a patch with tests, then I can apply it.
Bouiaw wrote:
> Symlinks are needed by some frameworks we use and that need some shared
> directories between several webapp.
> /home was just a sample, in our case we have symlink to a share /DATA
> repository.
>
> When you run mvn clean and that you loose all your /DATA (many gigabytes of
> data), I can say you that you feel strange !!!
>
> I don't say that symlinks are a good practice, we try to avoid them if
> possible. This is not always possible when your work in real world
> applications with some constraints (frameworks, infra).
>
> On Tue, May 5, 2009 at 9:20 AM, Paul MERLIN <pa...@nosphere.org> wrote:
>
>
>> Le mardi 05 mai 2009 00:12:55, Brian Fox a écrit :
>>
>>> Why would you have a symlink in your target folder to someplace
>>>
>> important?
>> Here is a quick example that came to my mind : Imagine you package a
>> tarball
>> containing such a symlink and that during the build you have to extract it
>> to
>> change something in there. Hop! you have a symlink to /home in target.
>>
>> /Paul
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Critical bugs pending on Maven clean plugin
Posted by Bouiaw <bo...@gmail.com>.
Symlinks are needed by some frameworks we use and that need some shared
directories between several webapp.
/home was just a sample, in our case we have symlink to a share /DATA
repository.
When you run mvn clean and that you loose all your /DATA (many gigabytes of
data), I can say you that you feel strange !!!
I don't say that symlinks are a good practice, we try to avoid them if
possible. This is not always possible when your work in real world
applications with some constraints (frameworks, infra).
On Tue, May 5, 2009 at 9:20 AM, Paul MERLIN <pa...@nosphere.org> wrote:
> Le mardi 05 mai 2009 00:12:55, Brian Fox a écrit :
> > Why would you have a symlink in your target folder to someplace
> important?
> Here is a quick example that came to my mind : Imagine you package a
> tarball
> containing such a symlink and that during the build you have to extract it
> to
> change something in there. Hop! you have a symlink to /home in target.
>
> /Paul
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: Critical bugs pending on Maven clean plugin
Posted by Paul MERLIN <pa...@nosphere.org>.
Le mardi 05 mai 2009 00:12:55, Brian Fox a écrit :
> Why would you have a symlink in your target folder to someplace important?
Here is a quick example that came to my mind : Imagine you package a tarball
containing such a symlink and that during the build you have to extract it to
change something in there. Hop! you have a symlink to /home in target.
/Paul
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: Critical bugs pending on Maven clean plugin
Posted by Brian Fox <br...@infinity.nu>.
Why would you have a symlink in your target folder to someplace important?
On Mon, May 4, 2009 at 5:25 PM, Bouiaw <bo...@gmail.com> wrote:
> Hi,
>
> Sorry to write again about clean plugin, but there is currently 2 VERY big
> bugs in Maven clean with no workaround.
>
> http://jira.codehaus.org/browse/MCLEAN-32 : when you have a big project
> with
> a lot of files (very common with war), Maven load in memory a complete
> object representatof of the files that are in the target directory. With
> one
> of our projects that have some thousand of files, Maven fails to clean
> target directory with a out of memory error even if we have set XMX to 768
> Mbytes !!! A rm -rf take 3 seconds and use no memory !
>
> http://jira.codehaus.org/browse/MCLEAN-39 : if you have a symlink in your
> target that for example to /home directory, run mvn clean on the project.
> Result : no more files in your /home directory. mvn clean follow symlink BY
> DEFAULT and there is no way to avoid that even with additional
> configuration
> !
>
> These are 2 oustanding issues that affect every body using Maven, I hope
> Brian or anybody else will be able to fix these bugs.
>
> Regards,
> Bouiaw
>