You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/24 21:41:44 UTC
Review Request 38730: Do not retry close on EINTR.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38730/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3512
https://issues.apache.org/jira/browse/MESOS-3512
Repository: mesos
Description
-------
See: https://issues.apache.org/jira/browse/MESOS-3512
Diffs
-----
src/slave/containerizer/linux_launcher.cpp 6e266bd567d7182c66038822b2d77922d12fe8a1
src/tests/containerizer/isolator_tests.cpp a25ae97a519feb8ead6177da160df8a276ca15bf
Diff: https://reviews.apache.org/r/38730/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38730: Do not retry close on EINTR.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38730/#review100473
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 24, 2015, 7:41 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38730/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 7:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3512
> https://issues.apache.org/jira/browse/MESOS-3512
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See: https://issues.apache.org/jira/browse/MESOS-3512
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp 6e266bd567d7182c66038822b2d77922d12fe8a1
> src/tests/containerizer/isolator_tests.cpp a25ae97a519feb8ead6177da160df8a276ca15bf
>
> Diff: https://reviews.apache.org/r/38730/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38730: Do not retry close on EINTR.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38730/#review100462
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38729, 38730]
All tests passed.
- Mesos ReviewBot
On Sept. 24, 2015, 7:41 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38730/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2015, 7:41 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3512
> https://issues.apache.org/jira/browse/MESOS-3512
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See: https://issues.apache.org/jira/browse/MESOS-3512
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp 6e266bd567d7182c66038822b2d77922d12fe8a1
> src/tests/containerizer/isolator_tests.cpp a25ae97a519feb8ead6177da160df8a276ca15bf
>
> Diff: https://reviews.apache.org/r/38730/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>