You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/26 02:33:16 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #742: fix: ingress do not watching any namespace when namespaceSelector is empty

tao12345666333 commented on a change in pull request #742:
URL: https://github.com/apache/apisix-ingress-controller/pull/742#discussion_r757194316



##########
File path: pkg/ingress/compare.go
##########
@@ -42,7 +43,7 @@ func (c *Controller) CompareResources(ctx context.Context) error {
 		consumerMapA6    = make(map[string]string)
 	)
 	// watchingNamespace == nil means to monitor all namespaces
-	if c.watchingNamespace == nil {
+	if !validation.HasValueInSyncMap(c.watchingNamespace) {

Review comment:
       @tokers I hope we can reach an agreement in this regard.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org