You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/28 16:56:37 UTC
[GitHub] [airflow] jedcunningham commented on a change in pull request #20517: fix README support matrix
jedcunningham commented on a change in pull request #20517:
URL: https://github.com/apache/airflow/pull/20517#discussion_r775993794
##########
File path: BREEZE.rst
##########
@@ -834,7 +834,7 @@ To use your host IDE with Breeze:
`pyenv <https://github.com/pyenv/pyenv>`_, `pyenv-virtualenv <https://github.com/pyenv/pyenv-virtualenv>`_,
or `virtualenvwrapper <https://virtualenvwrapper.readthedocs.io/en/latest/>`_.
- Ideally, you should have virtualenvs for all Python versions supported by Airflow (3.5, 3.6, 3.7)
+ Ideally, you should have virtualenvs for all Python versions supported by Airflow (3.7)
Review comment:
```suggestion
Ideally, you should have virtualenvs for all Python versions supported by Airflow (3.7, 3.8, 3.9)
```
##########
File path: README.md
##########
@@ -84,9 +84,9 @@ Apache Airflow is tested with:
| | Main version (dev) | Stable version (2.2.3) |
| -------------------- | -------------------- | ------------------------ |
-| Python | 3.6, 3.7, 3.8, 3.9 | 3.6, 3.7, 3.8, 3.9 |
-| Kubernetes | 1.20, 1.21 | 1.18, 1.19, 1.20 |
-| PostgreSQL | 10, 11, 12, 13 | 9.6, 10, 11, 12, 13 |
+| Python | 3.7, 3.8, 3.9 | 3.7, 3.7, 3.8, 3.9 |
+| Kubernetes | 1.20, 1.21 | 1.20, 1.21 |
+| PostgreSQL | 10, 11, 12, 13 | 10, 11, 12, 13 |
Review comment:
```suggestion
| Python | 3.7, 3.8, 3.9 | 3.6, 3.7, 3.8, 3.9 |
| Kubernetes | 1.20, 1.21 | 1.18, 1.19, 1.20 |
| PostgreSQL | 10, 11, 12, 13 | 9.6, 10, 11, 12, 13 |
```
I think these should stay for 2.2.3, they won't get changed until 2.3.0 I believe. (Am I right @potiuk?)
##########
File path: docs/apache-airflow/howto/set-up-database.rst
##########
@@ -86,7 +86,7 @@ You can make sure which version is used by the interpreter by running this check
.. code-block:: bash
root@b8a8e73caa2c:/opt/airflow# python
- Python 3.6.12 (default, Nov 25 2020, 03:59:00)
+ Python 3.7.12 (default, Nov 25 2020, 03:59:00)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
Review comment:
```suggestion
```
This one shouldn't be changed. Maybe we just rip out all this since it isn't really important?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org