You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by ja...@apache.org on 2019/08/09 06:49:47 UTC

svn commit: r1864771 - /httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags

Author: jailletc36
Date: Fri Aug  9 06:49:46 2019
New Revision: 1864771

URL: http://svn.apache.org/viewvc?rev=1864771&view=rev
Log:
Fix a corner case where automatic APLOGNO number generation generates invalid code. (see r1864733 fixed in r1864736, thx Eric)

Not sure why this ,? is there, but it looks uneeded to me.
There is maybe a link with the patterns used in 'find-messages.cocci'. They seem to add some extra , after the empty APLOGNO() it generates.
I will investigate further and fix 'find-messages.cocci' accordingly if needed.

Modified:
    httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags

Modified: httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags?rev=1864771&r1=1864770&r2=1864771&view=diff
==============================================================================
--- httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags (original)
+++ httpd/httpd/trunk/docs/log-message-tags/update-log-msg-tags Fri Aug  9 06:49:46 2019
@@ -37,7 +37,7 @@ sub process
     my $modified;
     my $result = "";
     while (defined $line) {
-        if ($line =~ s{APLOGNO\(\),?}{gen_tag($file)}e) {
+        if ($line =~ s{APLOGNO\(\)}{gen_tag($file)}e) {
             $modified = 1;
         }
         if ($line =~ /APLOGNO\(\s*(\d{5})\s*\)/ ) {