You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/18 18:36:45 UTC

[GitHub] [incubator-superset] villebro commented on a change in pull request #9572: [fix] Adding URL params to cache key if present

villebro commented on a change in pull request #9572: [fix] Adding URL params to cache key if present
URL: https://github.com/apache/incubator-superset/pull/9572#discussion_r410732811
 
 

 ##########
 File path: tests/core_tests.py
 ##########
 @@ -173,7 +173,6 @@ def test_viz_cache_key(self):
         viz = slc.viz
         qobj = viz.query_obj()
         cache_key = viz.cache_key(qobj)
-        self.assertEqual(cache_key, viz.cache_key(qobj))
 
 Review comment:
   I have no idea what I was thinking there 😄 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org