You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/08/14 09:53:32 UTC
[GitHub] [kylin] ITzhangqiang opened a new pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
ITzhangqiang opened a new pull request #1360:
URL: https://github.com/apache/kylin/pull/1360
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1360:
URL: https://github.com/apache/kylin/pull/1360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] coveralls commented on pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#issuecomment-674018555
## Pull Request Test Coverage Report for [Build 6252](https://coveralls.io/builds/32756950)
* **0** of **4** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **9** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-0.002%**) to **28.025%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://coveralls.io/builds/32756950/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHFileJob.java#L61) | 0 | 4 | 0.0%
<!-- | **Total:** | **0** | **4** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java](https://coveralls.io/builds/32756950/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Fsteps%2FCubeHFileJob.java#L106) | 1 | 0% |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/32756950/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/32756950/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/32756950/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L555) | 4 | 77.81% |
<!-- | **Total:** | **9** | | -->
| Totals | [](https://coveralls.io/builds/32756950) |
| :-- | --: |
| Change from base [Build 6246](https://coveralls.io/builds/32709065): | -0.002% |
| Covered Lines: | 26235 |
| Relevant Lines: | 93612 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#discussion_r472731647
##########
File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java
##########
@@ -101,6 +102,7 @@ public int run(String[] args) throws Exception {
// Automatic config !
HFileOutputFormat3.configureIncrementalLoad(job, htable);
+ tmpPartitionFilePath = new Path(TotalOrderPartitioner.getPartitionFile(job.getConfiguration()));
Review comment:
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#discussion_r472589799
##########
File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java
##########
@@ -69,13 +68,6 @@ public static Configuration getCurrentConfiguration() {
}
public static Configuration healSickConfig(Configuration conf) {
- // https://issues.apache.org/jira/browse/KYLIN-953
Review comment:
There are some places calling this method, please check whether impact others.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#issuecomment-685234383
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
zzcclp commented on pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#issuecomment-683526784
I hava tested this pr on docker, it worked fine, test steps:
1. when building a segment, check the path '/tmp/hbase-staging', there were some 'partitions_' files;
2. when build successfully, the '/tmp/hbase-staging/partitions_' files were deleted;
3. set property 'hbase.fs.tmp.dir' to '/tmp/hbase-tmp', and re-run step 1 and step 2, the 'partitions_' which were in '/tmp/hbase-tmp' were deleted when build successfully, it worked fine.
LGTM, and @hit-lacus please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#discussion_r472589173
##########
File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java
##########
@@ -101,6 +102,7 @@ public int run(String[] args) throws Exception {
// Automatic config !
HFileOutputFormat3.configureIncrementalLoad(job, htable);
+ tmpPartitionFilePath = new Path(TotalOrderPartitioner.getPartitionFile(job.getConfiguration()));
Review comment:
The value get from 'TotalOrderPartitioner.getPartitionFile' will be changed in method 'reconfigurePartitions', are you sure that the value of 'tmpPartitionFilePath' is right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] ITzhangqiang commented on a change in pull request #1360: KYLIN-4688 Too many tmp files in HDFS tmp dictionary
Posted by GitBox <gi...@apache.org>.
ITzhangqiang commented on a change in pull request #1360:
URL: https://github.com/apache/kylin/pull/1360#discussion_r472617186
##########
File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CubeHFileJob.java
##########
@@ -101,6 +102,7 @@ public int run(String[] args) throws Exception {
// Automatic config !
HFileOutputFormat3.configureIncrementalLoad(job, htable);
+ tmpPartitionFilePath = new Path(TotalOrderPartitioner.getPartitionFile(job.getConfiguration()));
Review comment:
I‘m sure，that‘s why I put 'TotalOrderPartitioner.getPartitionFile' up on the 'reconfigurePartitions'.
##########
File path: core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java
##########
@@ -69,13 +68,6 @@ public static Configuration getCurrentConfiguration() {
}
public static Configuration healSickConfig(Configuration conf) {
- // https://issues.apache.org/jira/browse/KYLIN-953
Review comment:
I checked,there is no affects on others.Because these two configurations belong to Hbase, where Hbase is used, HbaseConnection is used to get the configuration.And in HBaseConnection#newHBaseConfiguration,special treatment is given to these two configurations in this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org