You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by asdf2014 <gi...@git.apache.org> on 2017/07/04 11:39:27 UTC
[GitHub] zookeeper pull request #301: ZOOKEEPER-2835: Run server with `-XX:+AlwaysPre...
GitHub user asdf2014 opened a pull request:
https://github.com/apache/zookeeper/pull/301
ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` jvm flag
Add `-XX:+AlwaysPreTouch` jvm flag for server, let jvm through demand-zeroed way to allocate memory once in place when the process started.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asdf2014/zookeeper ZOOKEEPER-2835
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/301.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #301
----
commit 56e51d5daea9233f72922965b609a6ff13c836b8
Author: asdf2014 <15...@qq.com>
Date: 2017-07-04T11:38:26Z
ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` jvm flag
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #301: ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` ...
Posted by asdf2014 <gi...@git.apache.org>.
Github user asdf2014 commented on the issue:
https://github.com/apache/zookeeper/pull/301
Hi @afine . Thanks for your comments. Your consider is entirely correct. But I found the [PR#16937](https://github.com/elastic/elasticsearch/pull/16937) from `elasticsearch`. And every node in our `elasticsearch` cluster always be set as huge [`ES_HEAP_SIZE`](https://www.elastic.co/guide/en/elasticsearch/guide/current/heap-sizing.html) value. Then it just spend a few second when the `elasticsearch` instance start up. However, the server node in `zookeeper` cluster usually we don't assign too large memory. So, the `zookeeper` as daemon instance will get more benefit from it. (PS, same tuning in [Cassandra](https://tobert.github.io/tldr/cassandra-java-huge-pages.html), [Jenkins](https://jenkins.io/blog/2016/11/21/gc-tuning/) etc.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #301: ZOOKEEPER-2835: Run server with `-XX:+AlwaysPreTouch` ...
Posted by afine <gi...@git.apache.org>.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/301
I'm not sure if we should make this default configuration since it should increase startup time and will only increase performance for users with larger memory requirements. Our current default -XX args are pretty conservative and we don't really have any performance related switches there. Perhaps we should document this as a recommendation rather than making this default?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---