[GitHub] mcvsubbu commented on a change in pull request #3868: Disable realtime aggregate metrics if multi value dimension present

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #3868: Disable realtime aggregate metrics if multi value dimension present
URL: https://github.com/apache/incubator-pinot/pull/3868#discussion_r259552467
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
 ##########
 @@ -668,6 +668,7 @@ private int getOrCreateDocId(Map<String, Object> dictIdMap) {
     int i = 0;
     int[] dictIds = new int[_numKeyColumns]; // dimensions + time column.
 
+    // TODO: this for loop breaks for multi value columns. https://github.com/apache/incubator-pinot/issues/3867
 
 Review comment:
   we dont need this TODO anymore right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org