[jira] [Commented] (MESOS-93) Add unit tests for webui

["jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258085#comment-13258085 ] 

jiraposter@reviews.apache.org commented on MESOS-93:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4823/
-----------------------------------------------------------

Review request for mesos and Charles Reiss.


Summary
-------

Python Testcases for webui

*added unit testcases for checking if the webui could break by inputing artificial test jsons
*should catch bugs if there syntax issues, or general cases where resources doesn't add up correctly
*moved most of the logic out of the bottle .tpl template file and into the common webui_lib.py


This addresses bug MESOS-93.
    https://issues.apache.org/jira/browse/MESOS-93


Diffs
-----

  src/webui/common/run_testcases.py PRE-CREATION 
  src/webui/common/testcases.py PRE-CREATION 
  src/webui/common/webui_lib.py 0c56fde 
  src/webui/master/framework.tpl b29d2da 
  src/webui/master/index.tpl 68ae313 
  src/webui/slave/executor.tpl dd53464 
  src/webui/slave/framework.tpl 9488da5 
  src/webui/slave/index.tpl b2e2097 

Diff: https://reviews.apache.org/r/4823/diff


Testing
-------


Thanks,

terencekwt


                
> Add unit tests for webui
> ------------------------
>
>                 Key: MESOS-93
>                 URL: https://issues.apache.org/jira/browse/MESOS-93
>             Project: Mesos
>          Issue Type: Improvement
>          Components: test, webui
>            Reporter: Charles Reiss
>            Assignee: Terence Tam
>              Labels: test, webui
>
> The WebUI should have unit tests. Ideally, these tests should mock out the Master and Slave entirely and thus be pure python tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira