You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/05 01:58:12 UTC
[GitHub] [arrow-rs] tfeda opened a new pull request, #1648: Pretty Print `UnionArray`s
tfeda opened a new pull request, #1648:
URL: https://github.com/apache/arrow-rs/pull/1648
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1594 .
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Pretty printing support for `UnionArray`. My first stab is based on how they look in the [specification](https://arrow.apache.org/docs/format/Columnar.html#union-layout), but I can change it according to any suggestions:
Example:
```+------------+
| Teamsters |
"+------------+
| {a=1} |
| {b=3.2234} |
| {b=} |
| {a=} |
+------------+
```
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1648: Pretty Print `UnionArray`s
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1648:
URL: https://github.com/apache/arrow-rs/pull/1648#discussion_r865555032
##########
arrow/src/util/pretty.rs:
##########
@@ -647,6 +648,146 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_pretty_format_dense_union() -> Result<()> {
+ let mut builder = UnionBuilder::new_dense(4);
+ builder.append::<Int32Type>("a", 1).unwrap();
+ builder.append::<Float64Type>("b", 3.2234).unwrap();
+ builder.append_null::<Float64Type>("b").unwrap();
+ builder.append_null::<Int32Type>("a").unwrap();
+ let union = builder.build().unwrap();
+
+ let schema = Schema::new(vec![Field::new(
+ "Teamsters",
+ DataType::Union(
+ vec![
+ Field::new("a", DataType::Int32, false),
+ Field::new("b", DataType::Float64, false),
+ ],
+ UnionMode::Dense,
+ ),
+ false,
+ )]);
+
+ let batch =
+ RecordBatch::try_new(Arc::new(schema), vec![Arc::new(union)]).unwrap();
+ let table = pretty_format_batches(&[batch])?.to_string();
+ let actual: Vec<&str> = table.lines().collect();
+ let expected = vec![
+ "+------------+",
+ "| Teamsters |",
+ "+------------+",
+ "| {a=1} |",
+ "| {b=3.2234} |",
+ "| {b=} |",
+ "| {a=} |",
+ "+------------+",
+ ];
+
+ assert_eq!(expected, actual);
+ Ok(())
+ }
+
+ #[test]
+ fn test_pretty_format_sparse_union() -> Result<()> {
+ let mut builder = UnionBuilder::new_sparse(4);
+ builder.append::<Int32Type>("a", 1).unwrap();
+ builder.append::<Float64Type>("b", 3.2234).unwrap();
+ builder.append_null::<Float64Type>("b").unwrap();
+ builder.append_null::<Int32Type>("a").unwrap();
+ let union = builder.build().unwrap();
+
+ let schema = Schema::new(vec![Field::new(
+ "Teamsters",
+ DataType::Union(
+ vec![
+ Field::new("a", DataType::Int32, false),
+ Field::new("b", DataType::Float64, false),
+ ],
+ UnionMode::Sparse,
+ ),
+ false,
+ )]);
+
+ let batch =
+ RecordBatch::try_new(Arc::new(schema), vec![Arc::new(union)]).unwrap();
+ let table = pretty_format_batches(&[batch])?.to_string();
+ let actual: Vec<&str> = table.lines().collect();
+ let expected = vec![
+ "+------------+",
+ "| Teamsters |",
+ "+------------+",
+ "| {a=1} |",
+ "| {b=3.2234} |",
+ "| {b=} |",
+ "| {a=} |",
+ "+------------+",
+ ];
+
+ assert_eq!(expected, actual);
+ Ok(())
+ }
+
+ #[test]
+ fn test_pretty_format_nested_union() -> Result<()> {
+ //Inner UnionArray
+ let mut builder = UnionBuilder::new_dense(4);
+ builder.append::<Int32Type>("b", 1).unwrap();
+ builder.append::<Float64Type>("c", 3.2234).unwrap();
+ builder.append_null::<Float64Type>("c").unwrap();
+ builder.append_null::<Int32Type>("b").unwrap();
Review Comment:
Can you let outer show one null value from inner UnionArray too?
##########
arrow/src/util/display.rs:
##########
@@ -395,13 +396,49 @@ pub fn array_value_to_string(column: &array::ArrayRef, row: usize) -> Result<Str
Ok(s)
}
+ DataType::Union(field_vec, mode) => union_to_string(column, row, field_vec, mode),
_ => Err(ArrowError::InvalidArgumentError(format!(
"Pretty printing not implemented for {:?} type",
column.data_type()
))),
}
}
+/// Converts the value of the union array at `row` to a String
+fn union_to_string(
+ column: &array::ArrayRef,
+ row: usize,
+ fields: &[Field],
+ mode: &UnionMode,
+) -> Result<String> {
+ let list = column
+ .as_any()
+ .downcast_ref::<array::UnionArray>()
+ .ok_or_else(|| {
+ ArrowError::InvalidArgumentError(
+ "Repl error: could not convert union column to union array.".to_string(),
+ )
+ })?;
+ let type_id = list.type_id(row);
+ let name = fields
+ .get(type_id as usize)
+ .ok_or_else(|| {
+ ArrowError::InvalidArgumentError(
+ "Repl error: could not get field for the corresponding type in union array."
+ .to_string(),
Review Comment:
Maybe have `type_id` in error string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #1648: Pretty Print `UnionArray`s
Posted by GitBox <gi...@apache.org>.
viirya merged PR #1648:
URL: https://github.com/apache/arrow-rs/pull/1648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1648: Pretty Print `UnionArray`s
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1648:
URL: https://github.com/apache/arrow-rs/pull/1648#issuecomment-1118102055
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1648?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1648](https://codecov.io/gh/apache/arrow-rs/pull/1648?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3961f23) into [master](https://codecov.io/gh/apache/arrow-rs/commit/e51de5eb7ef40a4a35324e28d120df5495b68c6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e51de5e) will **increase** coverage by `0.01%`.
> The diff coverage is `91.25%`.
```diff
@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
+ Coverage 83.08% 83.09% +0.01%
==========================================
Files 193 193
Lines 55778 55858 +80
==========================================
+ Hits 46343 46416 +73
- Misses 9435 9442 +7
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1648?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/util/display.rs](https://codecov.io/gh/apache/arrow-rs/pull/1648/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvZGlzcGxheS5ycw==) | `71.20% <61.11%> (-0.77%)` | :arrow_down: |
| [arrow/src/util/pretty.rs](https://codecov.io/gh/apache/arrow-rs/pull/1648/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvcHJldHR5LnJz) | `97.20% <100.00%> (+0.66%)` | :arrow_up: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1648/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.40% <0.00%> (-0.40%)` | :arrow_down: |
| [arrow/src/array/transform/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1648/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9tb2QucnM=) | `86.57% <0.00%> (-0.12%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1648/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `66.43% <0.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1648?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1648?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e51de5e...3961f23](https://codecov.io/gh/apache/arrow-rs/pull/1648?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org