You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/04/30 04:02:34 UTC
Review Request 46863: Refactored FlagsBase::load() to move duplicate
checking logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
Diff: https://reviews.apache.org/r/46863/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 46863: Refactored FlagsBase::load() to move
duplicate checking logic.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/#review131238
-----------------------------------------------------------
Bad patch!
Reviews applied: [46863, 46669, 46624, 46623, 46622, 46621, 46814, 46620]
Failed command: ./support/apply-review.sh -n -r 46621
Error:
2016-04-30 02:32:01 URL:https://reviews.apache.org/r/46621/diff/raw/ [14455/14455] -> "46621.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp:498: Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
Total errors found: 1
Checking 2 files
Full log: https://builds.apache.org/job/mesos-reviewbot/12815/console
- Mesos ReviewBot
On April 30, 2016, 2:02 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46863/
> -----------------------------------------------------------
>
> (Updated April 30, 2016, 2:02 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-5271
> https://issues.apache.org/jira/browse/MESOS-5271
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The logic is now moved to Flag::load() keep the duplicate checking logic
> for names and aliases in one place.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
>
> Diff: https://reviews.apache.org/r/46863/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 46863: Refactored FlagsBase::load() to move
duplicate checking logic.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46863/
-----------------------------------------------------------
(Updated April 30, 2016, 3:44 a.m.)
Review request for mesos and Michael Park.
Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271
Repository: mesos
Description
-------
The logic is now moved to Flag::load() keep the duplicate checking logic
for names and aliases in one place.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp c3cbcdb781e1c282d381de1ad2bf4f386ee1db21
Diff: https://reviews.apache.org/r/46863/diff/
Testing
-------
make check
Thanks,
Vinod Kone