[jira] [Commented] (BEAM-1763) TestPipeline should ensure that all assertions succeeded

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997151#comment-15997151 ] 

ASF GitHub Bot commented on BEAM-1763:
--------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2729


> TestPipeline should ensure that all assertions succeeded
> --------------------------------------------------------
>
>                 Key: BEAM-1763
>                 URL: https://issues.apache.org/jira/browse/BEAM-1763
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core
>            Reporter: Thomas Groh
>            Assignee: Aviem Zur
>
> This doesn't need to be part of each {{PipelineRunner}} implementation if it goes through the {{PipelineResult}} APIs. The assertion can be of the form that if the Pipeline is finished, then the number of successful assertions is equal to the total number of assertions.
> Suggested solution:
> For runners which support metrics, use the counters for successful/failed assertions and compare them to expected number of assertions.
> Runners which do not support metrics should either implement metrics or override {{PAssert}} in a way that verifies its execution.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)