You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/05/10 02:15:07 UTC

[2/5] hbase git commit: HBASE-20554 "WALs outstanding" message from CleanerChore is noisy

HBASE-20554 "WALs outstanding" message from CleanerChore is noisy


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4ac2e171
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4ac2e171
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4ac2e171

Branch: refs/heads/branch-2.0
Commit: 4ac2e171c833335802c4f49d9d0c6e69fcff1414
Parents: ce72f9d
Author: Andrew Purtell <ap...@apache.org>
Authored: Wed May 9 10:16:44 2018 -0700
Committer: Andrew Purtell <ap...@apache.org>
Committed: Wed May 9 19:10:05 2018 -0700

----------------------------------------------------------------------
 .../hadoop/hbase/master/cleaner/CleanerChore.java       | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/4ac2e171/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index 8765a43..a003c6b 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -223,16 +223,22 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
   protected void chore() {
     if (getEnabled()) {
       if (runCleaner()) {
-        LOG.debug("Cleaned all WALs under {}",  oldFileDir);
+        if (LOG.isTraceEnabled()) {
+          LOG.trace("Cleaned all WALs under {}", oldFileDir);
+        }
       } else {
-        LOG.warn("WALs outstanding under {}", oldFileDir);
+        if (LOG.isTraceEnabled()) {
+          LOG.trace("WALs outstanding under {}", oldFileDir);
+        }
       }
       // After each clean chore, checks if receives reconfigure notification while cleaning
       if (reconfig.compareAndSet(true, false)) {
         updateChorePoolSize(CHOREPOOLSIZE);
       }
     } else {
-      LOG.debug("Cleaner chore disabled! Not cleaning.");
+      if (LOG.isTraceEnabled()) {
+        LOG.trace("Cleaner chore disabled! Not cleaning.");
+      }
     }
   }