You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Anita Jebaraj <aj...@us.ibm.com> on 2017/04/27 05:59:15 UTC

Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.


Bugs: AMBARI-20850
    https://issues.apache.org/jira/browse/AMBARI-20850


Repository: ambari


Description
-------

Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea 


Diff: https://reviews.apache.org/r/58780/diff/1/


Testing
-------

Tested Manually


File Attachments
----------------

error
  https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg


Thanks,

Anita Jebaraj

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

Posted by Anita Jebaraj <aj...@us.ibm.com>.

> On April 27, 2017, 6:15 a.m., Padma Priya N wrote:
> > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
> > Lines 193 (patched)
> > <https://reviews.apache.org/r/58780/diff/1/?file=1701053#file1701053line193>
> >
> >     It is better to use Ember.isBlank() instead of !=

I have updated in the new patch


- Anita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/#review173160
-----------------------------------------------------------


On April 27, 2017, 5:59 a.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58780/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 5:59 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20850
>     https://issues.apache.org/jira/browse/AMBARI-20850
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea 
> 
> 
> Diff: https://reviews.apache.org/r/58780/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Manually
> 
> 
> File Attachments
> ----------------
> 
> error
>   https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/#review173160
-----------------------------------------------------------




contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
Lines 193 (patched)
<https://reviews.apache.org/r/58780/#comment246236>

    It is better to use Ember.isBlank() instead of !=


- Padma Priya N


On April 27, 2017, 5:59 a.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58780/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 5:59 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20850
>     https://issues.apache.org/jira/browse/AMBARI-20850
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea 
> 
> 
> Diff: https://reviews.apache.org/r/58780/diff/1/
> 
> 
> Testing
> -------
> 
> Tested Manually
> 
> 
> File Attachments
> ----------------
> 
> error
>   https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/#review173293
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On April 27, 2017, 4:41 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58780/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 4:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20850
>     https://issues.apache.org/jira/browse/AMBARI-20850
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea 
> 
> 
> Diff: https://reviews.apache.org/r/58780/diff/2/
> 
> 
> Testing
> -------
> 
> Tested Manually
> 
> 
> File Attachments
> ----------------
> 
> error
>   https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

Posted by Anita Jebaraj <aj...@us.ibm.com>.

> On April 28, 2017, 5:24 a.m., Padma Priya N wrote:
> > Ship It!

Thank you for reviewing, can you please help in pushing the changes


- Anita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/#review173292
-----------------------------------------------------------


On April 27, 2017, 4:41 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58780/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 4:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20850
>     https://issues.apache.org/jira/browse/AMBARI-20850
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea 
> 
> 
> Diff: https://reviews.apache.org/r/58780/diff/2/
> 
> 
> Testing
> -------
> 
> Tested Manually
> 
> 
> File Attachments
> ----------------
> 
> error
>   https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/#review173292
-----------------------------------------------------------


Ship it!




Ship It!

- Padma Priya N


On April 27, 2017, 4:41 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58780/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 4:41 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-20850
>     https://issues.apache.org/jira/browse/AMBARI-20850
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea 
> 
> 
> Diff: https://reviews.apache.org/r/58780/diff/2/
> 
> 
> Testing
> -------
> 
> Tested Manually
> 
> 
> File Attachments
> ----------------
> 
> error
>   https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error

Posted by Anita Jebaraj <aj...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58780/
-----------------------------------------------------------

(Updated April 27, 2017, 4:41 p.m.)


Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, and Sangeeta Ravindran.


Bugs: AMBARI-20850
    https://issues.apache.org/jira/browse/AMBARI-20850


Repository: ambari


Description
-------

Clicking on search icon when the filter is empty in workflow dashboard throws the error Remote API failed as in screenshot


Diffs (updated)
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js 7e69dea 


Diff: https://reviews.apache.org/r/58780/diff/2/

Changes: https://reviews.apache.org/r/58780/diff/1-2/


Testing
-------

Tested Manually


File Attachments
----------------

error
  https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg


Thanks,

Anita Jebaraj