You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/11 18:27:58 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
GutoVeronezi opened a new pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386
### Description
We have a current discussion about using `commons.lang3` or our facade `com.cloud.utils` on the code, however a third implementation has been added (`google.common.base`), which end up adding more complexity to the discussion. The two variables of this discussion already implements all we need, therefore adding a third one does not make sense.
This PR primary intends to change `com.google.common.base.Strings`'s calls for `org.apache.commons.lang3.StringUtils`'s calls and after that, upgrade `org.apache.commons.lang.StringUtils`'s calls to `org.apache.commons.lang3.StringUtils`'s calls. Also, it will improve some minor codes related to `org.apache.commons.lang3.StringUtils` methods;
I choose `org.apache.commons.lang3.StringUtils` because our facade `com.cloud.utils.StringUtils` has a lack of methods to be a really facade of `org.apache.commons.lang3.StringUtils` and the methods it already implements are `deprecated`.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
-
---
EDIT 1
As we discussed in thread [[Discussion] String libs](https://lists.apache.org/thread.html/r806cd10b3de645c150e5e0e3d845c5a380a700197143f57f0834d758%40%3Cdev.cloudstack.apache.org%3E), voted in [[VOTE] Standard string lib](https://lists.apache.org/thread.html/rf8c21f7d8af2c85369c7ce2f8205dc8f1b24ebd0a24417ba501b79a0%40%3Cdev.cloudstack.apache.org%3E) and resulted in [[RESULT] [VOTE] Standard string lib](https://lists.apache.org/thread.html/r5898f717d506a0e160b9dc766b65769e2fe2f07f9cba70825843e272%40%3Cdev.cloudstack.apache.org%3E):
- `commons.lang3` will be our standard String library;
- `commons.lang` will be updated to `commons.lang3`;
- Unnecessary libraries will be replaced with `commons.lang3`;
- Unnecessary libraries will be added in module `IllegalImport`, in `checkstyle`;
- For String operations not covered by `commons.lang3`, we'll use our facade `com.cloud.utils.StringUtils`;
- In other PRs I will update code conventions and wiki/docs;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229394
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957288995
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957329833
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-908957077
I like the readability of Strings.isNullOrEmpty than isEmpty, maybe refactor everything to use cloud-utils's StringsUtils that wraps whatever favourite utility dependency you want to propose. Discuss on dev@ as Daan suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-940892033
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-943241045
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-971439316
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-966528432
Restart Jenkins...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-940733824
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-942764347
<b>Trillian test result (tid-2405)</b>
Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44989 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2405-vmware-70u1.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_CreateTemplateWithDuplicateName | `Error` | 1800.55 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 1907.08 | test_templates.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957329334
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-908957077
I like the readability of Strings.isNullOrEmpty than isEmpty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-941502510
<b>Trillian test result (tid-2393)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33641 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2393-xenserver-71.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-958140432
<b>Trillian test result (tid-2513)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32871 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2513-xenserver-71.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 355.41 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-946459948
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-909463414
> I like the readability of Strings.isNullOrEmpty than isEmpty, maybe refactor everything to use cloud-utils's StringsUtils that wraps whatever favourite utility dependency you want to propose. Discuss on dev@ as Daan suggests.
I agree that some methods can be more intuitive than others, however the point is to standardize what we're using. Soon I will start a discussion on the dev list, as @DaanHoogland suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-909463414
> I like the readability of Strings.isNullOrEmpty than isEmpty, maybe refactor everything to use cloud-utils's StringsUtils that wraps whatever favourite utility dependency you want to propose. Discuss on dev@ as Daan suggests.
I agree that some methods can be more intuitive than others, however the point is to standardize what we're using. Soon I will start a discussion on the dev list, as @DaanHoogland suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-966860106
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-968774452
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-971927141
<b>Trillian test result (tid-2556)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33340 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2556-vmware-65u2.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-942096851
@DaanHoogland unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, alma8, ubuntu18, suse15, ubuntu20, rocky8, centos8`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-rocky8, kvm-alma8, kvm-ubuntu18, kvm-ubuntu20, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-908957077
I like the readability of Strings.isNullOrEmpty than isEmpty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-940180950
Coding conventions were updated:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-940734816
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-940774264
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-941631689
<b>Trillian test result (tid-2395)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38995 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2395-vmware-65u2.zip
Smoke tests completed. 90 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_create_pvlan_network | `Error` | 0.03 | test_pvlan.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-971995414
<b>Trillian test result (tid-2554)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36047 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2554-xenserver-71.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-968732994
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi closed pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi closed pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957329203
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957288071
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on a change in pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#discussion_r728316650
##########
File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportUnmanagedInstanceCmd.java
##########
@@ -221,17 +221,17 @@ public Long getServiceOfferingId() {
if (MapUtils.isNotEmpty(nicIpAddressList)) {
for (Map<String, String> entry : (Collection<Map<String, String>>)nicIpAddressList.values()) {
String nic = entry.get(VmDetailConstants.NIC);
- String ipAddress = Strings.emptyToNull(entry.get(VmDetailConstants.IP4_ADDRESS));
+ String ipAddress = StringUtils.defaultIfEmpty(entry.get(VmDetailConstants.IP4_ADDRESS), null);
Review comment:
particularly, I prefer an inline IF over using a stringUtils method for the same purpose.
##########
File path: plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1426,7 +1426,7 @@ public VM createVmFromTemplate(final Connection conn, final VirtualMachineTO vmS
throw new CloudRuntimeException("Unable to finalize VM MetaData: " + vmSpec);
}
try {
- String bootMode = org.apache.commons.lang3.StringUtils.defaultIfEmpty(vmSpec.getDetails().get(ApiConstants.BootType.UEFI.toString()), null);
+ String bootMode = StringUtils.defaultIfEmpty(vmSpec.getDetails().get(ApiConstants.BootType.UEFI.toString()), null);
Review comment:
if you consider replacing the use of the "defaultIfEmpty" method in the above comment. perform these changes here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-942096277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957328678
@blueorangutan test centos7 vmware-70u1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] RodrigoDLopez commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-946271669
no technical reason at all. I'm fine with the defaultString method.
My apologies I ended up looking at things that have no connection with the proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-966862770
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-966840100
@GutoVeronezi is this ready for merging? And does it have a checkstyle or mvn check to ensure only this library is used throughout?
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-971885722
<b>Trillian test result (tid-2555)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29779 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2555-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-907161828
> I choose org.apache.commons.lang3.StringUtils because our facade com.cloud.utils.StringUtils has a lack of methods to be a really facade of org.apache.commons.lang3.StringUtils and the methods it already implements are deprecated.
@GutoVeronezi I see some of your argument, there is one thing that remains; if we ever need to upgrade and hit discrepancies we can fix them in one place if we use a facade. Did you start a discuss thread on this on the mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #5386: Replace com.google.common.base.Strings for org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-908957077
I like the readability of Strings.isNullOrEmpty than isEmpty, maybe refactor everything to use cloud-utils's StringsUtils that wraps whatever favourite utility dependency you want to propose. Discuss on dev@ as Daan suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957324760
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-956173920
@DaanHoogland could we re-run the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-946459737
no idea why we didn't get output from that last run, it did complete
@blueorangutan test centos7 vmware-70u1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-943240933
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-941425559
<b>Trillian test result (tid-2394)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31510 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2394-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-942096277
@blueorangutan test centos7 vmware70u1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-940894191
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-958126423
<b>Trillian test result (tid-2514)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31474 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5386-t2514-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-967044005
> @GutoVeronezi is this ready for merging? And does it have a checkstyle or mvn check to ensure only this library is used throughout?
@rhtyd yes, it is ready.
About the checkstyle checks, they were introduced through commit [Prohibit others string libs](https://github.com/apache/cloudstack/pull/5386/commits/13d3a029ec4d246ee9b77202a13a10d5d113b8d8).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi edited a comment on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-946156616
Hi @RodrigoDLopez, thanks for the review!
This PR intended to standardize the using of `org.apache.commons.lang3.StringUtils` and add some minor improvements, like changing:
```java
if (StringUtils.isEmpty(a) || StringUtils.isEmpty(b)) {
```
to
```java
if (StringUtils.isAnyEmpty(a, b)) {
```
And so on.
These minor improvements were made looking for code reducing and improving readability.
Changing:
```java
StringUtils.defaultIfEmpty(entry.get(VmDetailConstants.IP4_ADDRESS), null);
```
To:
```java
StringUtils.isEmpty(entry.get(VmDetailConstants.IP4_ADDRESS) ? null : entry.get(VmDetailConstants.IP4_ADDRESS;
```
Or:
```java
String var = entry.get(VmDetailConstants.IP4_ADDRESS);
StringUtils.defaultIfEmpty(var, null);
```
To:
```java
String var = entry.get(VmDetailConstants.IP4_ADDRESS);
StringUtils.isEmpty(var) ? null : var;
```
Sounds neither more nor less readable, for me.
Is there any technical reason to change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-942105545
@blueorangutan test centos7 vmware-70u1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-943240638
errors do not seem related.
re kicking the specific envs
@blueorangutan test centos7 vmware-70u1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-942105918
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-941425559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-966840289
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-968732277
Okay let's kick smoketest and merge the PR if they pass.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-966863095
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-971439609
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-957229022
sure @GutoVeronezi and I'll keep an eye on why it fails
@blueorangutan test centos7 vmware-70u1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #5386: Replace string libraries with org.apache.commons.lang3.StringUtils
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #5386:
URL: https://github.com/apache/cloudstack/pull/5386#issuecomment-946156616
Hi @RodrigoDLopez, thanks for the review!
This PR intended to standardize the using of `org.apache.commons.lang3.StringUtils` and add some minor improvements, like changing:
```java
if (StringUtils.isEmpty(a) || StringUtils.isEmpty(b)) {
```
to
```java
if (StringUtils.isAnyEmpty(a, b)) {
```
And so on.
These minor improvements were made looking for code reducing and improving readability.
Changing:
```java
StringUtils.defaultIfEmpty(entry.get(VmDetailConstants.IP4_ADDRESS), null);
```
To:
```java
StringUtils.isEmpty(entry.get(VmDetailConstants.IP4_ADDRESS) ? null : entry.get(VmDetailConstants.IP4_ADDRESS;
```
Or:
```java
String var = entry.get(VmDetailConstants.IP4_ADDRESS);
StringUtils.defaultIfEmpty(var, null);
```
To:
```java
String var = entry.get(VmDetailConstants.IP4_ADDRESS);
StringUtils.isEmpty(var) ? null : var;
```
Don't sounds neither more nor less readable, for me.
Is there any technical reason to change it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org