You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/22 23:31:10 UTC
[GitHub] [pulsar] merlimat opened a new pull request #7638: Revert "#7678 - changed root pom to use jetty bom (#7630)"
merlimat opened a new pull request #7638:
URL: https://github.com/apache/pulsar/pull/7638
This reverts commit e2368b80f4fda274cc57a44abb1f33067a979198. (#7630)
### Motivation
There's an issue with this change that makes tests fail in `tiered-storage/file-system`
```
[INFO] Running org.apache.bookkeeper.mledger.offload.filesystem.impl.FileSystemManagedLedgerOffloaderTest
[INFO] Running org.apache.bookkeeper.mledger.offload.filesystem.FileStoreTestBase
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.257 s - in org.apache.bookkeeper.mledger.offload.filesystem.FileStoreTestBase
[ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 1.558 s <<< FAILURE! - in org.apache.bookkeeper.mledger.offload.filesystem.impl.FileSystemManagedLedgerOffloaderTest
[ERROR] start(org.apache.bookkeeper.mledger.offload.filesystem.impl.FileSystemManagedLedgerOffloaderTest) Time elapsed: 1.499 s <<< FAILURE!
java.lang.NoClassDefFoundError: org/eclipse/jetty/util/ClassVisibilityChecker
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
```
I suspect that there could be a jetty module that is being picked up in the new version, while the plugin was trying to pin to an older version.
@vcottagiri Reverting for now to clear master CI (which is also already broker for Github env issues...), until we can sort it out.
I think the main problem, is that CI only ran the "license check" build since it was a modification of `pom.xml`, instead of running all the tests. Since the pom changes the deps, we should always run full tests in these cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se merged pull request #7638: Revert "#7678 - changed root pom to use jetty bom (#7630)"
Posted by GitBox <gi...@apache.org>.
aahmed-se merged pull request #7638:
URL: https://github.com/apache/pulsar/pull/7638
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vcottagiri commented on pull request #7638: Revert "#7678 - changed root pom to use jetty bom (#7630)"
Posted by GitBox <gi...@apache.org>.
vcottagiri commented on pull request #7638:
URL: https://github.com/apache/pulsar/pull/7638#issuecomment-662761557
Ok, sounds good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org