You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by as...@apache.org on 2026/07/21 14:59:34 UTC

(maven-source-plugin) branch master updated: Fix 'skin cannot be null' by declaring the fluido skin (beta-3 workaround)

This is an automated email from the ASF dual-hosted git repository.

ascheman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-source-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new dfbd925  Fix 'skin cannot be null' by declaring the fluido skin (beta-3 workaround)
dfbd925 is described below

commit dfbd9256b9ed62547e9999c37ab62fbbffce07d9
Author: Gerd Aschemann <as...@apache.org>
AuthorDate: Tue Jul 21 16:51:06 2026 +0200

    Fix 'skin cannot be null' by declaring the fluido skin (beta-3 workaround)
    
    The site 2.0.0 descriptor no longer defaults a skin, so maven-site-plugin
    3.22.0 fails the site build with 'skin cannot be null', which currently
    blocks the whole repo's CI.
    
    This is really a Maven 4.0.0-beta-3 core issue: beta-3 doesn't resolve the
    parent site descriptor, so the skin declared in the Maven parent isn't
    inherited. Parent resolution works again on 4.0.0-rc-5+, where this <skin>
    becomes redundant. Declare it explicitly to unblock CI on beta-3; a comment
    in site.xml documents that it should be dropped once the build moves off
    beta-3.
    
    Addresses review feedback from @slawekjaranowski. See apache/maven-site-plugin#1286.
    
    Co-Authored-By: Claude Fable 5 <no...@anthropic.com>
---
 src/site/site.xml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/site/site.xml b/src/site/site.xml
index f631ee6..9e0e193 100644
--- a/src/site/site.xml
+++ b/src/site/site.xml
@@ -21,6 +21,19 @@ under the License.
 
 <site xmlns="http://maven.apache.org/SITE/2.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
       xsi:schemaLocation="http://maven.apache.org/SITE/2.0.0 https://maven.apache.org/xsd/site-2.0.0.xsd">
+  <!--
+    Workaround for Maven 4.0.0-beta-3, the version this plugin currently builds against:
+    on beta-3 the parent site descriptor is not resolved, so the skin declared in the
+    Maven parent is not inherited and maven-site-plugin fails with "skin cannot be null".
+    Parent resolution works again on Maven 4.0.0-rc-5+, where this <skin> is redundant
+    (the parent's skin is inherited). Re-check and drop this once the build moves off
+    beta-3. See apache/maven-site-plugin#1286 for the cryptic-error part.
+  -->
+  <skin>
+    <groupId>org.apache.maven.skins</groupId>
+    <artifactId>maven-fluido-skin</artifactId>
+    <version>2.1.0</version>
+  </skin>
   <body>
     <menu name="Overview">
       <item name="Introduction" href="index.html"/>