You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Peter Bacsko (Jira)" <ji...@apache.org> on 2022/09/22 10:03:00 UTC

[jira] [Resolved] (YUNIKORN-1337) Application state stuck in "Accepted" when placeholders are running and the job is deleted

     [ https://issues.apache.org/jira/browse/YUNIKORN-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Bacsko resolved YUNIKORN-1337.
------------------------------------
     Fix Version/s: 1.2.0
    Target Version: 1.2.0
        Resolution: Fixed

Merged to master, thanks [~manirajv06@gmail.com] for the review.

> Application state stuck in "Accepted" when placeholders are running and the job is deleted
> ------------------------------------------------------------------------------------------
>
>                 Key: YUNIKORN-1337
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1337
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler
>    Affects Versions: 1.1.0
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.2.0
>
>
> The problem was introduced by YUNIKORN-1205.
> When the placeholders are running and the entire job is deleted, the application won't perform a state transition from Accepted to Completing. The reason is that there are still placeholder allocations, so {{removeAsksInternal()}} will not trigger it.
> On the other hand, when the allocations are removed, the innermost {{if}} branch will not be taken:
> {noformat}
> if alloc.placeholder {
> 		sa.allocatedPlaceholder = resources.Sub(sa.allocatedPlaceholder, alloc.AllocatedResource)
> 		// if all the placeholders are replaced, clear the placeholder timer
> 		if resources.IsZero(sa.allocatedPlaceholder) {
> 			sa.clearPlaceholderTimer()
> 			if (sa.IsCompleting() && sa.stateTimer == nil) || sa.IsFailing() || sa.IsResuming() {
>    ... // this will be skipped
> }
> {noformat}
> We have to check if there is no allocation left and then trigger a {{CompleteApplication}} event.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org