[GitHub] [apisix-ingress-controller] lingsamuel commented on pull request #689: feat: init ApisixPluginConfig crd (#638)

[GitBox <gi...@apache.org>]

lingsamuel commented on pull request #689:
URL: https://github.com/apache/apisix-ingress-controller/pull/689#issuecomment-927212290


   IMO this CRD is simple, we could use [kubebuilder markers](https://book.kubebuilder.io/reference/markers.html) to generate schema.
   
   This is a reference use case: https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/apisix/apis/config/v1/types.go#L272-L328
   
   After defining markers, run the following command in project root (assuming your are using linux) to regen the schema yaml:
   
   ```bash
   controller-gen schemapatch:manifests=./samples/deploy/crd/v1beta1  output:dir=./samples/deploy/crd/v1beta1 paths=./pkg/kube/apisix/...
   ```
   
   This command will raise some errors because not all CRD definitions works well with controller-gen. So you should rollback all changed files except fo ApisixPluginConfig one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org