You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by GitBox <gi...@apache.org> on 2021/06/21 14:19:19 UTC
[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH opened a new pull request #27: Add support for tee-supplicant loadable plugins
DemesneGH opened a new pull request #27:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/27
Hi @mssun
The loadable plugins framework is a new feature in OPTEE 3.13.0. It allows TA actively invoke a command defined in normal world plugins (which are compiled as .so dynlibs).See [this commit](https://github.com/OP-TEE/optee_client/commit/1e91cc797f72261fb03e7c2ce30944ff613ac07e).
In this commit I've updated:
1. In`optee-teec` `optee-utee` and `optee-utee-sys`:Wrap for related apis;
2. Add a new example `supp_plugin` for tee-supplicant plugins.The work logic is `host->TA->plugin`.Plugins are identified by uuid.
Best Regards,
Yuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] mssun commented on a change in pull request #27: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
mssun commented on a change in pull request #27:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/27#discussion_r652308289
##########
File path: optee-utee/src/extension.rs
##########
@@ -0,0 +1,36 @@
+use crate::{Error, Result, Uuid};
+use optee_utee_sys as raw;
+
+pub struct LoadablePlugin<'a> {
+ uuid: &'a Uuid
Review comment:
How about using `uuid: Uuid`. No need to have a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH commented on pull request #27: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
DemesneGH commented on pull request #27:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/27#issuecomment-865075855
New PR #29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH commented on pull request #27: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
DemesneGH commented on pull request #27:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/27#issuecomment-865075855
New PR #29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] mssun commented on a change in pull request #27: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
mssun commented on a change in pull request #27:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/27#discussion_r652308385
##########
File path: optee-utee/src/extension.rs
##########
@@ -0,0 +1,36 @@
+use crate::{Error, Result, Uuid};
+use optee_utee_sys as raw;
+
+pub struct LoadablePlugin<'a> {
+ uuid: &'a Uuid
+}
+
+impl<'a> LoadablePlugin<'a> {
+ pub fn new(uuid: &'a Uuid) -> Self {
+ Self { uuid }
Review comment:
-> `Self { uuid: uuid.to_owned() }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH closed pull request #27: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
DemesneGH closed pull request #27:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org
[GitHub] [incubator-teaclave-trustzone-sdk] DemesneGH closed pull request #27: Add support for tee-supplicant loadable plugins
Posted by GitBox <gi...@apache.org>.
DemesneGH closed pull request #27:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org