You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/08 08:34:53 UTC

[GitHub] [arrow] xhochy commented on a change in pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

xhochy commented on a change in pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#discussion_r451375443



##########
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##########
@@ -183,6 +188,53 @@ struct UTF8Transform {
   }
 };
 
+template <typename StringType, typename Derived>
+struct BinaryToBoolean {

Review comment:
       Do you think you could also make `BinaryContainsExact` use this struct?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org