You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by treblereel <gi...@git.apache.org> on 2016/11/23 15:56:31 UTC
[GitHub] activemq-artemis pull request #896: ARTEMIS-865 Remove e.printStackTrace() f...
GitHub user treblereel opened a pull request:
https://github.com/apache/activemq-artemis/pull/896
ARTEMIS-865 Remove e.printStackTrace() from code
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-865
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/treblereel/activemq-artemis-wildfly JBEAP-7375
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #896
----
commit eab3be6ab7bed2c9c4904e6d02d7536eb9810676
Author: Dmitrii Tikhomirov <dt...@redhat.com>
Date: 2016-11-21T14:32:22Z
ARTEMIS-865 Remove e.printStackTrace() from code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #896: ARTEMIS-865 Remove e.printStackTrace() from cod...
Posted by treblereel <gi...@git.apache.org>.
Github user treblereel commented on the issue:
https://github.com/apache/activemq-artemis/pull/896
strange error ... line 803 contains no code :
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ artemis-openwire-protocol ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 12 source files to /home/jenkins/jenkins-slave/workspace/ActiveMQ-Artemis-PR-Build/artemis-protocols/artemis-openwire-protocol/target/classes
/home/jenkins/jenkins-slave/workspace/ActiveMQ-Artemis-PR-Build/artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java:803: error: logger has private access in AbstractRemotingConnection
logger.warn("Failed to fire advisory on " + topic, e);
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #896: ARTEMIS-865 Remove e.printStackTrace() f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #896: ARTEMIS-865 Remove e.printStackTrace() from cod...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/896
I fixed it before merging.. it was using the private logger from a super class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #896: ARTEMIS-865 Remove e.printStackTrace() from cod...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/896
nice one.. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---