You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/02/16 14:41:20 UTC

Review Request 43601: LENS-961: Remove unused dependencies from lens parent pom

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43601/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-961
    https://issues.apache.org/jira/browse/LENS-961


Repository: lens


Description
-------


Diffs
-----

  pom.xml b3afa598dcd203c52369f384e58f4d41e21ddf1e 

Diff: https://reviews.apache.org/r/43601/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 43601: LENS-961: Remove unused dependencies from lens parent pom

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43601/#review119441
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On Feb. 17, 2016, 10:27 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43601/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 10:27 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-961
>     https://issues.apache.org/jira/browse/LENS-961
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> removed dependencies from dependency management if they were not used in any of the child modules.
> 
> 
> Diffs
> -----
> 
>   lens-server/pom.xml 8dba837ad85c72a3c87a4aad2f62895d87559de8 
>   pom.xml b3afa598dcd203c52369f384e58f4d41e21ddf1e 
> 
> Diff: https://reviews.apache.org/r/43601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 43601: LENS-961: Remove unused dependencies from lens parent pom

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43601/
-----------------------------------------------------------

(Updated Feb. 17, 2016, 3:57 p.m.)


Review request for lens.


Bugs: LENS-961
    https://issues.apache.org/jira/browse/LENS-961


Repository: lens


Description
-------

removed dependencies from dependency management if they were not used in any of the child modules.


Diffs (updated)
-----

  lens-server/pom.xml 8dba837ad85c72a3c87a4aad2f62895d87559de8 
  pom.xml b3afa598dcd203c52369f384e58f4d41e21ddf1e 

Diff: https://reviews.apache.org/r/43601/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 43601: LENS-961: Remove unused dependencies from lens parent pom

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43601/#review119429
-----------------------------------------------------------




pom.xml (line 1345)
<https://reviews.apache.org/r/43601/#comment180804>

    I think we can remove all jetty dependency as well.


- Amareshwari Sriramadasu


On Feb. 17, 2016, 4:46 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43601/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 4:46 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-961
>     https://issues.apache.org/jira/browse/LENS-961
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> removed dependencies from dependency management if they were not used in any of the child modules.
> 
> 
> Diffs
> -----
> 
>   pom.xml b3afa598dcd203c52369f384e58f4d41e21ddf1e 
> 
> Diff: https://reviews.apache.org/r/43601/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 43601: LENS-961: Remove unused dependencies from lens parent pom

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43601/
-----------------------------------------------------------

(Updated Feb. 17, 2016, 10:16 a.m.)


Review request for lens.


Bugs: LENS-961
    https://issues.apache.org/jira/browse/LENS-961


Repository: lens


Description (updated)
-------

removed dependencies from dependency management if they were not used in any of the child modules.


Diffs (updated)
-----

  pom.xml b3afa598dcd203c52369f384e58f4d41e21ddf1e 

Diff: https://reviews.apache.org/r/43601/diff/


Testing
-------


Thanks,

Rajat Khandelwal