[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4124: [CARBONDATA-4173][CARBONDATA-4174] Fix inverted index query issue and handle exception for desc column

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #4124:
URL: https://github.com/apache/carbondata/pull/4124#discussion_r618988679



##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/columnar/ByteArrayColumnWithRowId.java
##########
@@ -42,7 +42,7 @@ public short getRowId() {
   @Override
   public int compareTo(ByteArrayColumnWithRowId o) {
     return UnsafeComparer.INSTANCE
-        .compareTo(column, 2, column.length - 2, o.column, 2, o.column.length - 2);
+        .compareTo(column, 0, column.length, o.column, 0, o.column.length);

Review comment:
       I can see that they were ignoring first two bytes before as it was LV and L is short length field. 
   So, now you have changed it to compare whole array. that means it is not coming as LV now ? 
   which PR has induced it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org