You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/06 20:21:53 UTC

[GitHub] [tvm] tkonolige opened a new pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

tkonolige opened a new pull request #7994:
URL: https://github.com/apache/tvm/pull/7994


   @hogepodge 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on a change in pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7994:
URL: https://github.com/apache/tvm/pull/7994#discussion_r628448897



##########
File path: vta/tutorials/frontend/deploy_classification.py
##########
@@ -63,6 +63,8 @@
 
 # Make sure that TVM was compiled with RPC=1
 assert tvm.runtime.enabled("rpc")
+# Make sure vta is available
+assert tvm.get_global_func("tvm.contrib.vta.init", True) is not None

Review comment:
       I believe https://github.com/apache/tvm/pull/7761 already checks if vta binary is available




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tkonolige commented on a change in pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7994:
URL: https://github.com/apache/tvm/pull/7994#discussion_r628335127



##########
File path: vta/tutorials/frontend/deploy_classification.py
##########
@@ -63,6 +63,8 @@
 
 # Make sure that TVM was compiled with RPC=1
 assert tvm.runtime.enabled("rpc")
+# Make sure vta is available
+assert tvm.get_global_func("tvm.contrib.vta.init", True) is not None

Review comment:
       What function can I check then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on a change in pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7994:
URL: https://github.com/apache/tvm/pull/7994#discussion_r628268088



##########
File path: vta/tutorials/frontend/deploy_classification.py
##########
@@ -63,6 +63,8 @@
 
 # Make sure that TVM was compiled with RPC=1
 assert tvm.runtime.enabled("rpc")
+# Make sure vta is available
+assert tvm.get_global_func("tvm.contrib.vta.init", True) is not None

Review comment:
       This function is not available in simulator and only available in rpc server to initialize the remote bitstream




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tkonolige closed pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
tkonolige closed pull request #7994:
URL: https://github.com/apache/tvm/pull/7994


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen edited a comment on pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #7994:
URL: https://github.com/apache/tvm/pull/7994#issuecomment-834472662


   This function is not available in simulator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7994:
URL: https://github.com/apache/tvm/pull/7994#issuecomment-834472662


   This function seems to be not available in simular


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen removed a comment on pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
tqchen removed a comment on pull request #7994:
URL: https://github.com/apache/tvm/pull/7994#issuecomment-834472662


   This function is not available in simulator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] hogepodge commented on pull request #7994: [FIX,DOCS] Prevent segfault when building docs when VTA is not available

Posted by GitBox <gi...@apache.org>.
hogepodge commented on pull request #7994:
URL: https://github.com/apache/tvm/pull/7994#issuecomment-833835149


   Thanks! VTA has been a thorn for me for a while, so this helps. I'll also update my own environment to make sure it's installed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org