You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (Created) (JIRA)" <ji...@apache.org> on 2012/04/16 23:44:18 UTC

[jira] [Created] (HADOOP-8286) Simplify getting a socket address from conf

Simplify getting a socket address from conf
-------------------------------------------

                 Key: HADOOP-8286
                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
             Project: Hadoop Common
          Issue Type: Improvement
          Components: conf
    Affects Versions: 0.23.0
            Reporter: Daryn Sharp
            Assignee: Daryn Sharp


{{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255594#comment-13255594 ] 

Hudson commented on HADOOP-8286:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #2085 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2085/])
    HADOOP-8286. Simplify getting a socket address from conf (Daryn Sharp via bobby) (Revision 1327108)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327108
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java

                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256588#comment-13256588 ] 

Hudson commented on HADOOP-8286:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1053 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1053/])
    HADOOP-8286. Simplify getting a socket address from conf (Daryn Sharp via bobby) (Revision 1327108)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327108
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java

                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255113#comment-13255113 ] 

Hadoop QA commented on HADOOP-8286:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522868/HADOOP-8286.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/860//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/860//console

This message is automatically generated.
                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Joseph Evans updated HADOOP-8286:
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
                   2.0.0
                   0.23.3
           Status: Resolved  (was: Patch Available)

Thanks Daryn.  I put this into trunk, branch-2, and branch-0.23
                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8286:
--------------------------------

    Attachment: HADOOP-8286.patch
    
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255623#comment-13255623 ] 

Hudson commented on HADOOP-8286:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2099 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2099/])
    HADOOP-8286. Simplify getting a socket address from conf (Daryn Sharp via bobby) (Revision 1327108)

     Result = ABORTED
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327108
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java

                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256519#comment-13256519 ] 

Hudson commented on HADOOP-8286:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1018 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1018/])
    HADOOP-8286. Simplify getting a socket address from conf (Daryn Sharp via bobby) (Revision 1327108)

     Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327108
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java

                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255591#comment-13255591 ] 

Hudson commented on HADOOP-8286:
--------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2158 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2158/])
    HADOOP-8286. Simplify getting a socket address from conf (Daryn Sharp via bobby) (Revision 1327108)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327108
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java

                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256502#comment-13256502 ] 

Hudson commented on HADOOP-8286:
--------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #231 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/231/])
    svn merge -c 1327108 from trunk. FIXES: HADOOP-8286. Simplify getting a socket address from conf (Daryn Sharp via bobby) (Revision 1327110)

     Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1327110
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java

                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.0, 3.0.0
>
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255586#comment-13255586 ] 

Robert Joseph Evans commented on HADOOP-8286:
---------------------------------------------

The patch looks good to me.  I assume that there are some follow on JIRAs that will use this.  I also assume that TestViewFsTrash is the same sporadic failure we have seen before.  +1
                
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HADOOP-8286) Simplify getting a socket address from conf

Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HADOOP-8286:
--------------------------------

    Status: Patch Available  (was: Open)
    
> Simplify getting a socket address from conf
> -------------------------------------------
>
>                 Key: HADOOP-8286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8286
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.23.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8286.patch
>
>
> {{NetUtils.createSocketAddr(addr, port, confKey}} will throw an exception with a descriptive message of a malformed conf value.  A corresponding {{conf#getSocketAddr}} would make it easier to use, and ensure that {{NetUtils}} is used to parse the address.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira