You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by ku...@apache.org on 2017/08/20 11:19:25 UTC

zeppelin git commit: [ZEPPELIN-2770] Zeppelin is not working in IE-11

Repository: zeppelin
Updated Branches:
  refs/heads/master 0d390ecae -> f942e6ccc


[ZEPPELIN-2770] Zeppelin is not working in IE-11

### What is this PR for?
There is a javascript error while loading zeppelin homepage in IE-11, causing a blank page to appear.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-2770](https://issues.apache.org/jira/browse/ZEPPELIN-2770)

### How should this be tested?
Try opening Zeppelin homepage in IE-11.

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A

Author: yammathe <bo...@nokia.com>

Closes #2527 from byamthev/IE_COMPATIBILITY and squashes the following commits:

2d7230e9 [yammathe] [ZEPPELIN-2770] Zeppelin is not working in IE-11
81cfde88 [yammathe] fix IE bug:  startsWith do not exists for string


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f942e6cc
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f942e6cc
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f942e6cc

Branch: refs/heads/master
Commit: f942e6cccbf86049682ae717aee814e751429c69
Parents: 0d390ec
Author: yammathe <bo...@nokia.com>
Authored: Wed Aug 16 12:38:46 2017 +0300
Committer: 1ambda <1a...@gmail.com>
Committed: Sun Aug 20 20:19:20 2017 +0900

----------------------------------------------------------------------
 zeppelin-web/src/app/app.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f942e6cc/zeppelin-web/src/app/app.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/app.js b/zeppelin-web/src/app/app.js
index 034de2a..d46d026 100644
--- a/zeppelin-web/src/app/app.js
+++ b/zeppelin-web/src/app/app.js
@@ -185,7 +185,7 @@ function auth () {
       $rootScope.ticket = angular.fromJson(response.data).body
 
       $rootScope.ticket.screenUsername = $rootScope.ticket.principal
-      if ($rootScope.ticket.principal.startsWith('#Pac4j')) {
+      if ($rootScope.ticket.principal.indexOf('#Pac4j') === 0) {
         let re = ', name=(.*?),'
         $rootScope.ticket.screenUsername = $rootScope.ticket.principal.match(re)[1]
       }