You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Jackson, Douglas" <dj...@ugs.com> on 2008/01/24 19:25:41 UTC
process and instance management bug
Hi!
There is a discrepancy between the code and the schema in the process
and instance management service. The document element is not set by the
code and it is a required element in the schema. The line of code that
set the
Document was commented out by revision 573153 (mszefler) with the
comment
"Merged BART branch into trunk.". On the BART branch it was commented
out
by revision 556155 (mszefler) with the comment "BART: misc".
-Doug.
I see a few ways to fix this:
1) Remove the document element from the schema.
2) Make the document element optional in the schema.
3) Uncomment the commented out code.
4) Set the document to an empty string in the code.
Because I do not know why the code is commented out I do not know which
way to proceed with a fix.
-Doug.
The schema as I see it looks like this:
<complexType name="tDeploymentInfo">
<annotation>
<documentation>Information about a BPEL process
deployment.</documentation>
</annotation>
<sequence>
<element name="package" type="xs:string">
<annotation>
<documentation>Deployment package the process was
deployed into.</documentation>
</annotation>
</element>
<element name="document" type="xs:string">
<annotation>
<documentation>File name of BPEL
document.</documentation>
</annotation>
</element>
<element name="deploy-date" type="xs:dateTime">
<annotation>
<documentation>Date the process was
deployed.</documentation>
</annotation>
</element>
The code has the setting of the document commented out:
TDeploymentInfo depinfo = info.addNewDeploymentInfo();
depinfo.setPackage(pconf.getPackage());
//depinfo.setDocument(pconf.getBpelDocument());
depinfo.setDeployDate(toCalendar(pconf.getDeployDate()));
depinfo.setDeployer(pconf.getDeployer());
Re: process and instance management bug
Posted by Tammo van Lessen <tv...@gmail.com>.
Hi Douglas,
thanks for reporting that and for the patch. Would you mind to file a
jira for that and attach the patch with the "Grant license to ASF for
inclusion in ASF works" button checked? We can only include it if the
license grant has been accepted... Sorry for the inconvenience!
Thanks,
Tammo
Jackson, Douglas wrote:
> Hi!
> I found another bug in the process and instance management service.
> I was running the list processes custom on an ode installation with one
> simple process deployed and got errors on the client side because the
> properties and endpoints elements were missing (they are required
> elements
> in the schema). Here is a patch that fixes it. Another way to fix it
> is
> to make the elements optional in the schema.
> -Doug.
>
> Index:
> bpel-runtime/src/main/java/org/apache/ode/bpel/engine/ProcessAndInstance
> ManagementImpl.java
> ===================================================================
> ---
> bpel-runtime/src/main/java/org/apache/ode/bpel/engine/ProcessAndInstance
> ManagementImpl.java (rev
> ision 612598)
> +++
> bpel-runtime/src/main/java/org/apache/ode/bpel/engine/ProcessAndInstance
> ManagementImpl.java (wor
> king copy)
> @@ -748,6 +748,9 @@
> propNode.appendChild(node2append);
> }
> }
> + else {
> + info.addNewProperties();
> + }
>
> OProcess oprocess = _server.getOProcess(pconf.getProcessId());
> if (custom.includeEndpoints() && oprocess != null) {
> @@ -766,6 +769,9 @@
> }
> }
> }
> + else {
> + info.addNewEndpoints();
> + }
>
> }
>
RE: process and instance management bug
Posted by "Jackson, Douglas" <dj...@ugs.com>.
Hi!
I found another bug in the process and instance management service.
I was running the list processes custom on an ode installation with one
simple process deployed and got errors on the client side because the
properties and endpoints elements were missing (they are required
elements
in the schema). Here is a patch that fixes it. Another way to fix it
is
to make the elements optional in the schema.
-Doug.
Index:
bpel-runtime/src/main/java/org/apache/ode/bpel/engine/ProcessAndInstance
ManagementImpl.java
===================================================================
---
bpel-runtime/src/main/java/org/apache/ode/bpel/engine/ProcessAndInstance
ManagementImpl.java (rev
ision 612598)
+++
bpel-runtime/src/main/java/org/apache/ode/bpel/engine/ProcessAndInstance
ManagementImpl.java (wor
king copy)
@@ -748,6 +748,9 @@
propNode.appendChild(node2append);
}
}
+ else {
+ info.addNewProperties();
+ }
OProcess oprocess = _server.getOProcess(pconf.getProcessId());
if (custom.includeEndpoints() && oprocess != null) {
@@ -766,6 +769,9 @@
}
}
}
+ else {
+ info.addNewEndpoints();
+ }
}
Re: process and instance management bug
Posted by Alex Boisvert <bo...@intalio.com>.
On 1/24/08, Jackson, Douglas <dj...@ugs.com> wrote:
>
> Hi!
> There is a discrepancy between the code and the schema in the process
> and instance management service. The document element is not set by the
> code and it is a required element in the schema. The line of code that
> set the
> Document was commented out by revision 573153 (mszefler) with the
> comment
> "Merged BART branch into trunk.". On the BART branch it was commented
> out
> by revision 556155 (mszefler) with the comment "BART: misc".
> -Doug.
>
> I see a few ways to fix this:
> 1) Remove the document element from the schema.
> 2) Make the document element optional in the schema.
> 3) Uncomment the commented out code.
> 4) Set the document to an empty string in the code.
>
> Because I do not know why the code is commented out I do not know which
> way to proceed with a fix.
Not sure why it was commented. I've uncommented the code in r614972.
Thanks for reporting this!
alex