You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/03/31 14:22:09 UTC

[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2847: [NETBEANS-5524] Check for priming action before use.

JaroslavTulach commented on a change in pull request #2847:
URL: https://github.com/apache/netbeans/pull/2847#discussion_r604939988



##########
File path: ide/projectui/src/org/netbeans/modules/project/ui/ProjectChooserAccessory.java
##########
@@ -346,7 +347,12 @@ private static int countPrimable(Iterable<Project> projects) {
         for (Project p : projects) {
             final Lookup lkp = p.getLookup();
             final ActionProvider ap = lkp.lookup(ActionProvider.class);
-            if (ap != null && ap.isActionEnabled(ActionProvider.COMMAND_PRIME, lkp)) {
+            if (ap == null) {
+                // a Project without any actions ? Most probably ergonomics-proxy, count it in!
+                cnt++;

Review comment:
       Wow, great idea!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists