You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Barry Brannan (JIRA)" <ji...@apache.org> on 2017/01/17 10:34:26 UTC
[jira] [Commented] (THRIFT-1548) PHP TCompactProtocol always reads
bools as false
[ https://issues.apache.org/jira/browse/THRIFT-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825805#comment-15825805 ]
Barry Brannan commented on THRIFT-1548:
---------------------------------------
this was fixed in THRIFT-3348
> PHP TCompactProtocol always reads bools as false
> ------------------------------------------------
>
> Key: THRIFT-1548
> URL: https://issues.apache.org/jira/browse/THRIFT-1548
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Library
> Affects Versions: 0.8
> Reporter: Gregory Hart
> Attachments: TCompactProtocol.php.patch
>
>
> In TCompactProtocol::readFieldBegin, $field_type should be compared to COMPACT_TRUE or COMPACT_FALSE before being converted to a TType. Otherwise, $field_type will be converted to TType::BOOL (0x02) and will always match COMPACT_FALSE (0x02).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)