You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/14 14:19:22 UTC
Review Request 68342: Added const versions of slave-counting
functions in Master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68342/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
The family of functions '_slaves_active()', etc. is logically
const, although the function signatures do not currently
reflect this due to MESOS-4995.
Since a const version of this functionality is required for
the changes introduced in the subsequent commits, it is
added with different names as a workaround.
Diffs
-----
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8
Diff: https://reviews.apache.org/r/68342/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68342: Added const versions of slave-counting
functions in Master.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68342/#review207406
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 14, 2018, 2:19 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68342/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 2:19 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The family of functions '_slaves_active()', etc. is logically
> const, although the function signatures do not currently
> reflect this due to MESOS-4995.
>
> Since a const version of this functionality is required for
> the changes introduced in the subsequent commits, it is
> added with different names as a workaround.
>
>
> Diffs
> -----
>
> src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
> src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8
>
>
> Diff: https://reviews.apache.org/r/68342/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68342: Added const versions of slave-counting
functions in Master.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68342/
-----------------------------------------------------------
(Updated Aug. 21, 2018, 6:46 a.m.)
Review request for mesos and Alexander Rukletsov.
Bugs: MESOS-9158
https://issues.apache.org/jira/browse/MESOS-9158
Repository: mesos
Description
-------
The family of functions '_slaves_active()', etc. is logically
const, although the function signatures do not currently
reflect this due to MESOS-4995.
Since a const version of this functionality is required for
the changes introduced in the subsequent commits, it is
added with different names as a workaround.
Diffs
-----
src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d
src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8
Diff: https://reviews.apache.org/r/68342/diff/1/
Testing (updated)
-------
See https://reviews.apache.org/r/68296/
Thanks,
Benno Evers