You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/11/29 11:21:32 UTC
Review Request 64151: Added an agent endpoint to list resource
providers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Repository: mesos
Description
-------
The 'resource_providers' endpoint will list all subscribed local
resource providers of an agent. It shows all informations that
are part of a 'ResourceProviderInfo'.
Diffs
-----
docs/endpoints/index.md 871153774c4b21cdca4afec9bc2ce2bd955b17c4
docs/endpoints/slave/resource_providers.md PRE-CREATION
src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9
src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
src/slave/http.cpp 394e91013dc11e0a79e2e00534864281cc74ad2f
src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285
src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45
Diff: https://reviews.apache.org/r/64151/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64151: Added an agent endpoint to list resource
providers.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review192232
-----------------------------------------------------------
src/slave/slave.cpp
Lines 804 (patched)
<https://reviews.apache.org/r/64151/#comment270262>
Hum, i think we stop adding v0 operator APIs. We should instead add a v1 operator API `GET_RESOURCE_PROVIDERS`
- Jie Yu
On Nov. 29, 2017, 11:23 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 11:23 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8270
> https://issues.apache.org/jira/browse/MESOS-8270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 'resource_providers' endpoint will list all subscribed local
> resource providers of an agent. It shows all informations that
> are part of a 'ResourceProviderInfo'.
>
>
> Diffs
> -----
>
> docs/endpoints/index.md 871153774c4b21cdca4afec9bc2ce2bd955b17c4
> docs/endpoints/slave/resource_providers.md PRE-CREATION
> src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9
> src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
> src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
> src/slave/http.cpp 394e91013dc11e0a79e2e00534864281cc74ad2f
> src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285
> src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45
>
>
> Diff: https://reviews.apache.org/r/64151/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review192860
-----------------------------------------------------------
include/mesos/agent/agent.proto
Lines 445 (patched)
<https://reviews.apache.org/r/64151/#comment271184>
Let's introduce a nested message `GetResourceProviders.ResourceProvider` here so that we can add more information later (e.g., resource provider-specific resources, offer operations, ...). This message would contain just a `repeated ResourceProvider resource_providers = 1` for now.
include/mesos/v1/agent/agent.proto
Lines 445 (patched)
<https://reviews.apache.org/r/64151/#comment271185>
Ditto.
- Benjamin Bannier
On Dec. 5, 2017, 10:48 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 10:48 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8270
> https://issues.apache.org/jira/browse/MESOS-8270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
> resource providers of an agent.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
> include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
> src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
> src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
> src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
> src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
> src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
> src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
> src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01
>
>
> Diff: https://reviews.apache.org/r/64151/diff/5/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review193238
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Dec. 8, 2017, 11:24 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 11:24 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8270
> https://issues.apache.org/jira/browse/MESOS-8270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
> resource providers of an agent.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
> include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
> src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
> src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
> src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
> src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
>
>
> Diff: https://reviews.apache.org/r/64151/diff/8/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/
-----------------------------------------------------------
(Updated Dec. 8, 2017, 11:24 a.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Addressed issues.
Bugs: MESOS-8270
https://issues.apache.org/jira/browse/MESOS-8270
Repository: mesos
Description
-------
The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
resource providers of an agent.
Diffs (updated)
-----
include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
Diff: https://reviews.apache.org/r/64151/diff/8/
Changes: https://reviews.apache.org/r/64151/diff/7-8/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/
-----------------------------------------------------------
(Updated Dec. 7, 2017, 3:32 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased on top of #64370.
Bugs: MESOS-8270
https://issues.apache.org/jira/browse/MESOS-8270
Repository: mesos
Description
-------
The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
resource providers of an agent.
Diffs (updated)
-----
include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
Diff: https://reviews.apache.org/r/64151/diff/7/
Changes: https://reviews.apache.org/r/64151/diff/6-7/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/resource_provider/manager.hpp
> > Lines 28 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909010#file1909010line28>
> >
> > Unused?
The latest rebase no longer changes ResourceProviderManager. Dropping.
> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/resource_provider/manager.hpp
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909010#file1909010line63>
> >
> > Could we explicitly include `mesos.hpp` for `ResourceProviderInfo`?
The latest rebase no longer changes ResourceProviderManager. Dropping.
> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/resource_provider/manager.cpp
> > Lines 466 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909011#file1909011line466>
> >
> > `foreachvalue`? We should also include `stout/foreach.hpp` here.
The latest rebase no longer changes ResourceProviderManager. Dropping.
> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 839 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909016#file1909016line839>
> >
> > Could we use a `MockResourceProvider` here as well?
The latest rebase no longer changes ResourceProviderManager. Dropping.
> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 880 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909016#file1909016line880>
> >
> > This needs to be an assert.
The latest rebase no longer changes ResourceProviderManager. Dropping.
> On Dec. 5, 2017, 6:06 p.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 881 (patched)
> > <https://reviews.apache.org/r/64151/diff/6/?file=1909016#file1909016line881>
> >
> > This needs to be tweaked if we use a `MockResourceProvider`.
The latest rebase no longer changes ResourceProviderManager. Dropping.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review192877
-----------------------------------------------------------
On Dec. 7, 2017, 3:32 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2017, 3:32 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8270
> https://issues.apache.org/jira/browse/MESOS-8270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
> resource providers of an agent.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
> include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
> src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
> src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
> src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
> src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
>
>
> Diff: https://reviews.apache.org/r/64151/diff/7/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/#review192877
-----------------------------------------------------------
include/mesos/agent/agent.proto
Lines 60 (patched)
<https://reviews.apache.org/r/64151/#comment271202>
Let's add some minimal documentation here.
include/mesos/v1/agent/agent.proto
Lines 60 (patched)
<https://reviews.apache.org/r/64151/#comment271203>
Let's add some minimal documentation here.
src/resource_provider/manager.hpp
Lines 28 (patched)
<https://reviews.apache.org/r/64151/#comment271205>
Unused?
src/resource_provider/manager.hpp
Lines 63 (patched)
<https://reviews.apache.org/r/64151/#comment271206>
Could we explicitly include `mesos.hpp` for `ResourceProviderInfo`?
src/resource_provider/manager.cpp
Lines 466 (patched)
<https://reviews.apache.org/r/64151/#comment271207>
`foreachvalue`? We should also include `stout/foreach.hpp` here.
src/slave/http.cpp
Lines 1862 (patched)
<https://reviews.apache.org/r/64151/#comment271208>
Let's create a ticket tracking authorization of this call and mention it in a `TODO` here.
src/slave/http.cpp
Lines 1879-1881 (patched)
<https://reviews.apache.org/r/64151/#comment271213>
This could become slightly less nasty if we would declare outside the loop a
agent::Response::GetResourceProviders* getResourceProviders =
response.mutable_get_resource_providers();
It does not help a lot though.
src/tests/api_tests.cpp
Lines 6046 (patched)
<https://reviews.apache.org/r/64151/#comment271218>
This would be much simpler with a `MockResourceProvider`.
src/tests/api_tests.cpp
Lines 6094-6095 (patched)
<https://reviews.apache.org/r/64151/#comment271220>
EXPECT_EQ(
1, v1Response->get_resource_providers().resource_providers_size());
src/tests/api_tests.cpp
Lines 6097 (patched)
<https://reviews.apache.org/r/64151/#comment271221>
We could bind to a const ref here.
src/tests/api_tests.cpp
Lines 6102 (patched)
<https://reviews.apache.org/r/64151/#comment271222>
This needs to be tweak if we use a `MockResourceProvider`.
src/tests/resource_provider_manager_tests.cpp
Lines 839 (patched)
<https://reviews.apache.org/r/64151/#comment271223>
Could we use a `MockResourceProvider` here as well?
src/tests/resource_provider_manager_tests.cpp
Lines 880 (patched)
<https://reviews.apache.org/r/64151/#comment271225>
This needs to be an assert.
src/tests/resource_provider_manager_tests.cpp
Lines 881 (patched)
<https://reviews.apache.org/r/64151/#comment271224>
This needs to be tweaked if we use a `MockResourceProvider`.
- Benjamin Bannier
On Dec. 5, 2017, 3:34 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64151/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2017, 3:34 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Bugs: MESOS-8270
> https://issues.apache.org/jira/browse/MESOS-8270
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
> resource providers of an agent.
>
>
> Diffs
> -----
>
> include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
> include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
> src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
> src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
> src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
> src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
> src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
> src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
> src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01
>
>
> Diff: https://reviews.apache.org/r/64151/diff/6/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 3:34 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Addressed issues.
Bugs: MESOS-8270
https://issues.apache.org/jira/browse/MESOS-8270
Repository: mesos
Description
-------
The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
resource providers of an agent.
Diffs (updated)
-----
include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01
Diff: https://reviews.apache.org/r/64151/diff/6/
Changes: https://reviews.apache.org/r/64151/diff/5-6/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/
-----------------------------------------------------------
(Updated Dec. 5, 2017, 10:48 a.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-8270
https://issues.apache.org/jira/browse/MESOS-8270
Repository: mesos
Description
-------
The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
resource providers of an agent.
Diffs (updated)
-----
include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
src/resource_provider/manager.hpp c2aeb15b0b8ebd167ddf9c42c9fc396d4c0a126b
src/resource_provider/manager.cpp 8d8b2f1396230d6edba590b8b7e9b4ca51366efe
src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
src/tests/api_tests.cpp 53c705ed4775846ba7eb42da57f962895f5669aa
src/tests/resource_provider_manager_tests.cpp a4c19ca769e66110d9aba0bae4792df9db3fed01
Diff: https://reviews.apache.org/r/64151/diff/5/
Changes: https://reviews.apache.org/r/64151/diff/4-5/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64151: Added a V1 API call to list resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/
-----------------------------------------------------------
(Updated Nov. 30, 2017, 3:11 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Use v1 API instead of v0.
Summary (updated)
-----------------
Added a V1 API call to list resource providers.
Bugs: MESOS-8270
https://issues.apache.org/jira/browse/MESOS-8270
Repository: mesos
Description (updated)
-------
The 'GET_RESOURCE_PROVIDERS' call will list all subscribed local
resource providers of an agent.
Diffs (updated)
-----
docs/endpoints/index.md 871153774c4b21cdca4afec9bc2ce2bd955b17c4
docs/endpoints/slave/resource_providers.md PRE-CREATION
include/mesos/agent/agent.proto 0f92f73ba0f7729f0ba7cd89a692ab3685125e8b
include/mesos/v1/agent/agent.proto 012ffef5f0dd7720fa95ae484c99479aaf256d7b
src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9
src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
src/slave/http.cpp fd0e809d5dc7722e573b66621f75d791f0911dfa
src/slave/validation.cpp 32781fd8f124f71e61744804aec3fe4da59a5df2
src/tests/api_tests.cpp 66cb059c96ff9ecda594e13de9e5dc3909feeee3
src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45
support/clang-format 64b529c482db9be48e12242fd32832596b2ad883
Diff: https://reviews.apache.org/r/64151/diff/2/
Changes: https://reviews.apache.org/r/64151/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 64151: Added an agent endpoint to list resource
providers.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64151/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 12:23 p.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Bugs: MESOS-8270
https://issues.apache.org/jira/browse/MESOS-8270
Repository: mesos
Description
-------
The 'resource_providers' endpoint will list all subscribed local
resource providers of an agent. It shows all informations that
are part of a 'ResourceProviderInfo'.
Diffs
-----
docs/endpoints/index.md 871153774c4b21cdca4afec9bc2ce2bd955b17c4
docs/endpoints/slave/resource_providers.md PRE-CREATION
src/resource_provider/manager.hpp e7a9a6cc6b15372d8f3f11e17fa2297792b00ff9
src/resource_provider/manager.cpp 5fdce7f1777c48029a979f3c77933e1753d6ba00
src/slave/http.hpp a51831cdcebc1998ce6d4c3c19285e598a4ec9a3
src/slave/http.cpp 394e91013dc11e0a79e2e00534864281cc74ad2f
src/slave/slave.cpp e1566832f90cca372ad2f1cc13d1e7f76fa53285
src/tests/resource_provider_manager_tests.cpp 0b7c4ad6bb0052847b884959e3171cd7ab382b45
Diff: https://reviews.apache.org/r/64151/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht