You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Chao Sun <ch...@cloudera.com> on 2014/10/03 01:43:11 UTC

Review Request 26296: HIVE-8331 - HIVE-8303 followup, investigate result diff [Spark Branch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26296/
-----------------------------------------------------------

Review request for hive and Xuefu Zhang.


Bugs: HIVE-8331
    https://issues.apache.org/jira/browse/HIVE-8331


Repository: hive-git


Description
-------

HIVE-8303 patch introduced some result diffs for some spark tests. We need to investigate those, including parallel_join0.q, union22.q, vectorized_shufflejoin.q, union_remove_18.q, and maybe more.
Also the investigation includes the test failures related to spark. Specifically, union_remove_18.q demonstrated random order.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java fed6ccd 
  ql/src/test/results/clientpositive/spark/union_remove_18.q.out 60ab60b 

Diff: https://reviews.apache.org/r/26296/diff/


Testing
-------


Thanks,

Chao Sun


Re: Review Request 26296: HIVE-8331 - HIVE-8303 followup, investigate result diff [Spark Branch]

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26296/#review55287
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java
<https://reviews.apache.org/r/26296/#comment95675>

    Had discussion with Tez folks and were told that thread-local for this map will not work for Tez. Have you found the root cause?


- Xuefu Zhang


On Oct. 2, 2014, 11:43 p.m., Chao Sun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26296/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2014, 11:43 p.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-8331
>     https://issues.apache.org/jira/browse/HIVE-8331
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-8303 patch introduced some result diffs for some spark tests. We need to investigate those, including parallel_join0.q, union22.q, vectorized_shufflejoin.q, union_remove_18.q, and maybe more.
> Also the investigation includes the test failures related to spark. Specifically, union_remove_18.q demonstrated random order.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/IOContext.java fed6ccd 
>   ql/src/test/results/clientpositive/spark/union_remove_18.q.out 60ab60b 
> 
> Diff: https://reviews.apache.org/r/26296/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chao Sun
> 
>