You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/01 09:01:45 UTC
[GitHub] [doris] cambyzju opened a new pull request, #12262: [fix](array-type) revert ARRAY
cambyzju opened a new pull request, #12262:
URL: https://github.com/apache/doris/pull/12262
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
Now there are still lots of bugs related to ARRAY<NOT_NULL(T)>.
We decide not to support nested element NOT NULLABLE for ARRAY type at the first version.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #12262: [fix](array-type) revert ARRAY
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #12262:
URL: https://github.com/apache/doris/pull/12262#discussion_r962096995
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -4847,8 +4847,6 @@ type ::=
{: RESULT = ScalarType.createVarcharType(-1); :}
| KW_ARRAY LESSTHAN type:value_type GREATERTHAN
{: RESULT = new ArrayType(value_type); :}
Review Comment:
What about using the following modification?
```suggestion
{:
RESULT = new ArrayType(value_type);
if (!((ArrayType) RESULT).getContainsNull()) {
throw new AnalysisException("ARRAY<NOT_NULL()> is unsupported.")
}
:}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12262: [fix](array-type) revert ARRAY
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12262:
URL: https://github.com/apache/doris/pull/12262#issuecomment-1236058196
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12262: [fix](array-type) revert ARRAY
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12262:
URL: https://github.com/apache/doris/pull/12262#issuecomment-1236058192
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] cambyzju commented on a diff in pull request #12262: [fix](array-type) revert ARRAY
Posted by GitBox <gi...@apache.org>.
cambyzju commented on code in PR #12262:
URL: https://github.com/apache/doris/pull/12262#discussion_r961885966
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -4847,8 +4847,6 @@ type ::=
{: RESULT = ScalarType.createVarcharType(-1); :}
| KW_ARRAY LESSTHAN type:value_type GREATERTHAN
{: RESULT = new ArrayType(value_type); :}
- | KW_ARRAY LESSTHAN KW_NOT_NULL LPAREN type:value_type RPAREN GREATERTHAN
- {: RESULT = new ArrayType(value_type, false); :}
Review Comment:
Lots of codes who called `new ArrayType` will also need to catch the exception, if we throw an exception while new ArrayType. I think just remove these too lines is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #12262: [fix](array-type) revert ARRAY
Posted by GitBox <gi...@apache.org>.
adonis0147 merged PR #12262:
URL: https://github.com/apache/doris/pull/12262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #12262: [fix](array-type) revert ARRAY
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #12262:
URL: https://github.com/apache/doris/pull/12262#discussion_r961267978
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -4847,8 +4847,6 @@ type ::=
{: RESULT = ScalarType.createVarcharType(-1); :}
| KW_ARRAY LESSTHAN type:value_type GREATERTHAN
{: RESULT = new ArrayType(value_type); :}
- | KW_ARRAY LESSTHAN KW_NOT_NULL LPAREN type:value_type RPAREN GREATERTHAN
- {: RESULT = new ArrayType(value_type, false); :}
Review Comment:
I think we can keep this syntax but just throw an exception due to we don't support it temporarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org