You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by kk...@apache.org on 2020/07/08 08:41:12 UTC

[flink] 02/02: [hotfix] Harden JarDeleteHandlerTest test

This is an automated email from the ASF dual-hosted git repository.

kkloudas pushed a commit to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 957c13c51dcd43e52f0e9a7a07e74acaae6f5073
Author: Kostas Kloudas <kk...@gmail.com>
AuthorDate: Mon Jul 6 20:53:35 2020 +0200

    [hotfix] Harden JarDeleteHandlerTest test
---
 .../apache/flink/runtime/webmonitor/handlers/JarDeleteHandlerTest.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandlerTest.java b/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandlerTest.java
index edbeca4..82e0660 100644
--- a/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandlerTest.java
+++ b/flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandlerTest.java
@@ -50,6 +50,7 @@ import static org.hamcrest.Matchers.containsString;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.instanceOf;
 import static org.junit.Assert.assertThat;
+import static org.junit.Assert.fail;
 
 /**
  * Unit tests for {@link JarDeleteHandler}.
@@ -105,7 +106,9 @@ public class JarDeleteHandlerTest extends TestLogger {
 			final RestHandlerException restHandlerException = (RestHandlerException) throwable;
 			assertThat(restHandlerException.getMessage(), containsString("File doesnotexist.jar does not exist in"));
 			assertThat(restHandlerException.getHttpResponseStatus(), equalTo(HttpResponseStatus.BAD_REQUEST));
+			return;
 		}
+		fail("The test should have failed by now.");
 	}
 
 	@Test