You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2025/12/08 01:18:11 UTC
[PR] GH-48386: [Ruby][Dev] Enable Layout/TrailingEmptyLines: final_newline cop [arrow]
hiroyuki-sato opened a new pull request, #48392:
URL: https://github.com/apache/arrow/pull/48392
### Rationale for this change
This fix introduces new Ruby formatting checks to streamline multi-person development.
### What changes are included in this PR?
Enable [`Layout/TrailingEmptyLines`](https://docs.rubocop.org/rubocop/cops_layout.html#layouttrailingemptylines) options
```ruby
# `final_newline` looks for one newline at the end of files.
# bad
class Foo; end
# EOF
# bad
class Foo; end # EOF
# good
class Foo; end
# EOF
```
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48386: [Ruby][Dev] Enable Layout/TrailingEmptyLines: final_newline cop [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #48392:
URL: https://github.com/apache/arrow/pull/48392#issuecomment-3624060762
:warning: GitHub issue #48386 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48386: [Ruby][Dev] Enable Layout/TrailingEmptyLines: final_newline cop [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48392:
URL: https://github.com/apache/arrow/pull/48392#issuecomment-3677683017
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ba27b8fe5311296ce98a92f8763cc98e2f0bfd56.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/58604367529) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-48386: [Ruby][Dev] Enable Layout/TrailingEmptyLines: final_newline cop [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #48392:
URL: https://github.com/apache/arrow/pull/48392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org