[jira] Issue Comment Edited: (HADOOP-3108) NPE in FSDirectory.unprotectedSetPermission

["Raghu Angadi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583109#action_12583109 ] 

rangadi edited comment on HADOOP-3108 at 3/28/08 10:56 AM:
----------------------------------------------------------------

Since this patch is meant for 16, I think its better if it only fixes the NPEs. Changing some of the IOExceptions to FileNotFound might be ok. But any other semantic changes probably belong in 17 or trunk. For example with the patch, deleting a file can throw IOException, where i think it should return false.

      was (Author: rangadi):
    I think this patch is meant for 16, its better if only fixes the NPE. Changing a few IOExceptions to FileNotFound might be ok. But any other semantic changes. For example with the patch, deleting a file can throw IOException, where i think it should return false.
  
> NPE in FSDirectory.unprotectedSetPermission
> -------------------------------------------
>
>                 Key: HADOOP-3108
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3108
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.16.1
>            Reporter: Koji Noguchi
>            Assignee: Konstantin Shvachko
>            Priority: Blocker
>             Fix For: 0.16.2
>
>         Attachments: 3108_20080327.patch, getNodeNPE.patch
>
>
> Not sure if this is fixed in later release, but I'm seeing many NPE in the namenode log.
> Permission is disabled on this cluster.
> {noformat} 
> 2008-03-27 03:22:39,984 INFO org.apache.hadoop.ipc.Server: IPC Server handler 18 on 8020, 
> call setPermission(/user/knoguchi/file0, rwxr-xr-x) from 99.9.99.9:55555: 
> error: java.io.IOException: java.lang.NullPointerException
> java.io.IOException: java.lang.NullPointerException
>         at org.apache.hadoop.dfs.FSDirectory.unprotectedSetPermission(FSDirectory.java:411)
>         at org.apache.hadoop.dfs.FSDirectory.setPermission(FSDirectory.java:405)
>         at org.apache.hadoop.dfs.FSNamesystem.setPermission(FSNamesystem.java:716)
>         at org.apache.hadoop.dfs.NameNode.setPermission(NameNode.java:297)
>         at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:409)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:899)
> {noformat} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.