[jira] [Commented] (ROCKETMQ-231) Pull result size is always less than given size in PullConsumer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108617#comment-16108617 ] 

ASF GitHub Bot commented on ROCKETMQ-231:
-----------------------------------------

Github user lindzh commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/126#discussion_r130558354
  
    --- Diff: store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java ---
    @@ -1110,7 +1110,7 @@ private boolean isTheBatchFull(int sizePy, int maxMsgNums, int bufferTotal, int
                 return false;
             }
     
    -        if ((messageTotal + 1) >= maxMsgNums) {
    --- End diff --
    
    Yes,this problem has been fixed to maxMsgNums <= messageTotal


> Pull result size is always less than given size in PullConsumer
> ---------------------------------------------------------------
>
>                 Key: ROCKETMQ-231
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-231
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-broker
>    Affects Versions: 4.0.0-incubating
>            Reporter: lindzh
>            Assignee: yukon
>            Priority: Critical
>             Fix For: 4.2.0-incubating
>
>
> When using PullConsumer pull message by default result size is 32,and messages is more than 32 in a queue,but broker always returns 31.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)