[jira] [Commented] (KARAF-6238) org.apache.karaf.profile.assembly.Builder#downloadLibraries is not synchronized

["Grzegorz Grzybek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KARAF-6238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817863#comment-16817863 ] 

Grzegorz Grzybek commented on KARAF-6238:
-----------------------------------------

Synchronization works:
{noformat}
$ ls -1 *-sorted.properties|wc -l
100

$ md5sum *-sorted.properties|awk '{print $1}'|sort|uniq
16cb7eff22b3ea4e267f941b7bdd1dec
{noformat}

> org.apache.karaf.profile.assembly.Builder#downloadLibraries is not synchronized
> -------------------------------------------------------------------------------
>
>                 Key: KARAF-6238
>                 URL: https://issues.apache.org/jira/browse/KARAF-6238
>             Project: Karaf
>          Issue Type: Bug
>            Reporter: Grzegorz Grzybek
>            Assignee: Grzegorz Grzybek
>            Priority: Blocker
>             Fix For: 4.3.0, 4.2.5
>
>
> I had strange case. Running:
> {noformat}
> for n in {1..100}; do
>     mvn clean install -DskipTests -f /path/to/custom-karaf-distro
>     cp /path/to/custom-karaf-distro/target/assembly/etc/config.properties /data/tmp/config-$n.properties
>     cat /path/to/custom-karaf-distro/target/assembly/etc/config.properties | sort > /data/tmp/config-$n-sorted.properties
> done
> {noformat}
> I was _usually_ getting the same config.propertie. But not always. Occasionally some extra packages were missing...
> Long story short, downloader uses 8 threads and {{org.apache.karaf.profile.assembly.Builder#downloadLibraries()}} uses the download callback without any synchronization...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)