[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9290: [Enhancement](Vectorized)build hash table with new thread, as non-vec…

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #9290:
URL: https://github.com/apache/incubator-doris/pull/9290#discussion_r878991830


##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -956,10 +956,44 @@ Status HashJoinNode::open(RuntimeState* state) {
         RETURN_IF_ERROR((*_vother_join_conjunct_ptr)->open(state));
     }
 
-    RETURN_IF_ERROR(_hash_table_build(state));
-    RETURN_IF_ERROR(child(0)->open(state));
+    std::promise<Status> thread_status;
+    std::thread(bind(&HashJoinNode::_hash_table_build_thread, this, state, &thread_status))
+            .detach();
+
+    if (_runtime_filter_descs.empty()) {
+        // Open the probe-side child so that it may perform any initialisation in parallel.
+        // Don't exit even if we see an error, we still need to wait for the build thread
+        // to finish.
+        // ISSUE-1247, check open_status after buildThread execute.

Review Comment:
   std::promise<Status> thread_status;
       std::thread(bind(&HashJoinNode::_hash_table_build_thread, this, state, &thread_status))
               .detach();



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org