You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/19 06:05:18 UTC
[GitHub] [arrow] arw2019 opened a new pull request #8002: ARROW-9532: [Python][Developer] add note re: cmake argument for Python executable
arw2019 opened a new pull request #8002:
URL: https://github.com/apache/arrow/pull/8002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#issuecomment-677235758
> Could you replace existing `PYTHON_EXECUTABLE` with `Python3_EXECUTABLE` and add note that "you need to use `PYTHON_EXECUTABLE` with CMake < 3.15" or something?
> It's better that we assume that most users have newer CMake not older CMake.
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#discussion_r473645378
##########
File path: python/setup.py
##########
@@ -224,7 +224,7 @@ def _run_cmake(self):
static_lib_option = ''
cmake_options = [
- '-DPYTHON_EXECUTABLE=%s' % sys.executable,
Review comment:
Ah, could you keep this?
If we have both `PYTHON_EXECUTABLE` and `Python3_EXECUTABLE`, it works on newer and older CMake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#issuecomment-676706601
Thanks.
Could you replace existing `PYTHON_EXECUTABLE` with `Python3_EXECUTABLE` and add note that "you need to use `PYTHON_EXECUTABLE` with CMake < 3.15" or something?
It's better that we assume that most users have newer CMake not older CMake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#discussion_r473645378
##########
File path: python/setup.py
##########
@@ -224,7 +224,7 @@ def _run_cmake(self):
static_lib_option = ''
cmake_options = [
- '-DPYTHON_EXECUTABLE=%s' % sys.executable,
Review comment:
Ah, could you keep this?
If we can both `PYTHON_EXECUTABLE` and `Python3_EXECUTABLE`, it works on newer and older CMake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#issuecomment-677387688
Thanks @kou for reviewing!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8002:
URL: https://github.com/apache/arrow/pull/8002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on a change in pull request #8002: ARROW-9532: [Python][Developer] add note re: cmake argument for Python executable
Posted by GitBox <gi...@apache.org>.
arw2019 commented on a change in pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#discussion_r472740105
##########
File path: docs/source/developers/python.rst
##########
@@ -148,7 +148,7 @@ Pull in the test data and setup the environment variables:
git submodule update
export PARQUET_TEST_DATA="${PWD}/cpp/submodules/parquet-testing/data"
export ARROW_TEST_DATA="${PWD}/testing/data"
-
+ popd
Review comment:
This is a nitpick: without it you need to do `popd` by hand before the next step
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8002: ARROW-9532: [Python][Developer] add note re: cmake argument for Python executable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#issuecomment-675871520
https://issues.apache.org/jira/browse/ARROW-9532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on a change in pull request #8002: ARROW-9532: [Python][Doc] Use Python3_EXECUTABLE instead of PYTHON_EXECUTABLE for finding Python executable
Posted by GitBox <gi...@apache.org>.
arw2019 commented on a change in pull request #8002:
URL: https://github.com/apache/arrow/pull/8002#discussion_r473660611
##########
File path: python/setup.py
##########
@@ -224,7 +224,7 @@ def _run_cmake(self):
static_lib_option = ''
cmake_options = [
- '-DPYTHON_EXECUTABLE=%s' % sys.executable,
Review comment:
For sure!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org