You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/30 09:36:49 UTC
[GitHub] [iotdb] GOptimistic opened a new pull request #4671: [IOTDB-2214] InfluxDB-Connect write point time error format
GOptimistic opened a new pull request #4671:
URL: https://github.com/apache/iotdb/pull/4671
see https://issues.apache.org/jira/browse/IOTDB-2214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #4671: [IOTDB-2214] InfluxDB-Connect write point time error format
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #4671:
URL: https://github.com/apache/iotdb/pull/4671#issuecomment-1002948341
Hi @GOptimistic, nice to see u here!
Let's add some tests for the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4671: [IOTDB-2214] InfluxDB-Connect write point time error format
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4671:
URL: https://github.com/apache/iotdb/pull/4671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4671: [IOTDB-2214] InfluxDB-Connect write point time error format
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4671:
URL: https://github.com/apache/iotdb/pull/4671#discussion_r776901574
##########
File path: server/src/main/java/org/apache/iotdb/db/utils/TimeUtil.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.utils;
+
+import java.util.concurrent.TimeUnit;
+
+public class TimeUtil {
Review comment:
Move it to DateTimeUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jun0315 commented on pull request #4671: [IOTDB-2214] InfluxDB-Connect write point time error format
Posted by GitBox <gi...@apache.org>.
jun0315 commented on pull request #4671:
URL: https://github.com/apache/iotdb/pull/4671#issuecomment-1003516817
@GOptimistic Great! Thanks a lot for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org