[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8

[GitBox <gi...@apache.org>]

Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8
URL: https://github.com/apache/incubator-echarts/pull/11186#discussion_r336340512
 
 

 ##########
 File path: src/coord/Axis.js
 ##########
 @@ -301,12 +303,16 @@ function fixOnBandTicksCoords(axis, ticksCoords, tickCategoryInterval, alignWith
 
     var axisExtent = axis.getExtent();
     var last;
+    var diffSize;
     if (ticksLen === 1) {
         ticksCoords[0].coord = axisExtent[0];
         last = ticksCoords[1] = {coord: axisExtent[0]};
     }
     else {
-        var shift = (ticksCoords[1].coord - ticksCoords[0].coord);
+
+        var crossLen = ticksCoords[ticksLen-1].tickValue - ticksCoords[0].tickValue;
 
 Review comment:
   Space is required around `-`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org