You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@slider.apache.org by te...@apache.org on 2014/11/12 20:04:40 UTC

incubator-slider git commit: Add javadoc for SliderAppMaster#registerComponent()

Repository: incubator-slider
Updated Branches:
  refs/heads/develop affa457e6 -> 3e711eba0


Add javadoc for SliderAppMaster#registerComponent()


Project: http://git-wip-us.apache.org/repos/asf/incubator-slider/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-slider/commit/3e711eba
Tree: http://git-wip-us.apache.org/repos/asf/incubator-slider/tree/3e711eba
Diff: http://git-wip-us.apache.org/repos/asf/incubator-slider/diff/3e711eba

Branch: refs/heads/develop
Commit: 3e711eba0200d87eb73ec4fd480cc16cebf6f220
Parents: affa457
Author: tedyu <yu...@gmail.com>
Authored: Wed Nov 12 11:04:35 2014 -0800
Committer: tedyu <yu...@gmail.com>
Committed: Wed Nov 12 11:04:35 2014 -0800

----------------------------------------------------------------------
 .../java/org/apache/slider/server/appmaster/SliderAppMaster.java  | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-slider/blob/3e711eba/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
----------------------------------------------------------------------
diff --git a/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java b/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
index 7000583..bab359c 100644
--- a/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
+++ b/slider-core/src/main/java/org/apache/slider/server/appmaster/SliderAppMaster.java
@@ -547,6 +547,7 @@ public class SliderAppMaster extends AbstractSliderLaunchedService
 
   /**
    * Create and run the cluster.
+   * @param clustername
    * @return exit code
    * @throws Throwable on a failure
    */
@@ -1113,6 +1114,7 @@ the registry with/without the new record format
    * Register/re-register an ephemeral container that is already in the app state
    * @param id the component
    * @param description
+   * @return true if the component is registered
    */
   public boolean registerComponent(ContainerId id, String description) throws
       IOException {
@@ -1133,6 +1135,7 @@ the registry with/without the new record format
     } catch (IOException e) {
       log.warn("Failed to register container {}/{}: {}",
           id, description, e, e);
+      return false;
     }
     return true;
   }