[GitHub] [ignite-3] alievmirza commented on a diff in pull request #2072: IGNITE-19342 Some tests from DistributionZoneManagerScaleUpTest were fixed and enabled.

["alievmirza (via GitHub)" <gi...@apache.org>]

alievmirza commented on code in PR #2072:
URL: https://github.com/apache/ignite-3/pull/2072#discussion_r1194748622


##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -672,7 +689,7 @@ void testUpdateZoneScaleUpTriggersDataNodePropagation() throws Exception {
 
         assertDataNodesForZone(1, Set.of(), keyValueStorage);
 
-        assertZoneScaleDownChangeTriggerKey(1, 1, keyValueStorage);
+        assertZoneScaleDownChangeTriggerKey(3L, 1, keyValueStorage);

Review Comment:
   This check is useless. Let's check that this key become non-null after zone creation or remove check completely 



##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/DistributionZoneManagerScaleUpTest.java:
##########
@@ -672,7 +689,7 @@ void testUpdateZoneScaleUpTriggersDataNodePropagation() throws Exception {
 
         assertDataNodesForZone(1, Set.of(), keyValueStorage);
 
-        assertZoneScaleDownChangeTriggerKey(1, 1, keyValueStorage);
+        assertZoneScaleDownChangeTriggerKey(3L, 1, keyValueStorage);

Review Comment:
   please check also the same logic below



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org