You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "biyuhao (GitHub)" <gi...@apache.org> on 2019/01/01 06:08:44 UTC
[GitHub] [incubator-dubbo-ops] biyuhao opened pull request #222:
Return BAD_REQUEST for parameter error
Should return `HttpStatus.BAD_REQUEST` for bad parameter requests.
```
http 127.0.0.1:8080/api/dev/service
HTTP/1.1 500
Connection: close
Content-Type: application/json;charset=UTF-8
Date: Tue, 01 Jan 2019 06:00:51 GMT
Transfer-Encoding: chunked
{
"message": "System Error, please try again later! Message:Required String parameter 'pattern' is not present",
"success": false
}
```
should be
```
http 127.0.0.1:8080/api/dev/service
HTTP/1.1 400
Connection: close
Content-Type: application/json;charset=UTF-8
Date: Tue, 01 Jan 2019 06:01:27 GMT
Transfer-Encoding: chunked
{
"message": "Parameter validation failure! Message:Required String parameter 'pattern' is not present",
"success": false
}
```
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/222 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #222:
Return BAD_REQUEST for parameter error
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=h1) Report
> Merging [#222](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/3c9e24b00619af2888e78a4b278cf0a4d4d8a291?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #222 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3278 3280 +2
Branches 519 521 +2
============================================
Hits 19 19
- Misses 3258 3260 +2
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dubbo/admin/handler/CustomExceptionHandler.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vaGFuZGxlci9DdXN0b21FeGNlcHRpb25IYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ava/org/apache/dubbo/admin/model/domain/Route.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL1JvdXRlLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=footer). Last update [3c9e24b...208a3a6](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/222 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #222:
Return BAD_REQUEST for parameter error
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
Thank you for your pr, I'll merge it
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/222 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #222:
Return BAD_REQUEST for parameter error
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=h1) Report
> Merging [#222](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/3c9e24b00619af2888e78a4b278cf0a4d4d8a291?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #222 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3278 3280 +2
Branches 519 521 +2
============================================
Hits 19 19
- Misses 3258 3260 +2
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/dubbo/admin/handler/CustomExceptionHandler.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vaGFuZGxlci9DdXN0b21FeGNlcHRpb25IYW5kbGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ava/org/apache/dubbo/admin/model/domain/Route.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZG9tYWluL1JvdXRlLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=footer). Last update [3c9e24b...208a3a6](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/222?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/222 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #222:
Return BAD_REQUEST for parameter error
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
[ pull request closed by nzomkxia ]
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/222 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org