[GitHub] merrimanr opened a new pull request #1340: METRON-2007: Management UI not loading grok statements correctly

[GitBox <gi...@apache.org>]

merrimanr opened a new pull request #1340: METRON-2007: Management UI not loading grok statements correctly
URL: https://github.com/apache/metron/pull/1340
 
 
   ## Contributor Comments
   I believe these regressions happened when upgrading Angular:
   
   - The `responseType` needs to be set to `string` for any REST calls that return a String type.  I also fixed `kafka.service.ts` even though it's not directly related to this issue.
   - The `grokStatement` type was incorrectly changed from string to Object in `sensor-parser-config.component.ts` so I changed it back and handled casting it in the callback.
   
   ### Testing
   This has been tested in full dev.  Before this fix opening either a squid or yaf sensor would throw an error about not being able to load the grok statement from HDFS or the classpath.  After this fix you should be able to open either sensor with the grok statement correctly loaded and displayed.  You should also be able to create a new Grok sensor and have the pattern label automatically populated with the sensor name.
   
   ### Outstanding Issues
   - Fixing this subsequently causes an "Expression has changed after it was checked"  error in the browser console.  I believe the offending line is [here](https://github.com/apache/metron/blob/master/metron-interface/metron-config/src/app/sensors/sensor-parser-config/sensor-parser-config.component.html#L200).
   - I have not updated or run the unit tests yet
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   
   ### For code changes:
   - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [x] Have you included steps or a guide to how the change may be verified and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services